Matt Fishman
Matt Fishman
We could wrap that functionality up into a nicer interface, maybe: ```julia subkeys(collection::NamedTuple, keys) = getindices(collection, (; (keys .=> keys)...)) subkeys(collection::Dict, keys) = getindices(collection, Dict(keys .=> keys)) ``` to be...
I'll try to take another look through it to see if I have any more comments. @emstoudenmire could you do another pass over it as well?
> Thank you @mtfishman for the review. As you noticed, there are many parts involving `UnitRangeDual` that are not satisfying. There is no good solution with the current design `UnitRangeDual...
> One minor thing I just noticed when pulling this branch is that there's a Project.toml file in `NDTensors/src/lib/Sectors/` but which is empty (i.e. the file has no lines). I...
@ogauthe thanks for the update to `categories_fusion_rule`, that's definitely already easier to understand. I'll take a look over it again and leave comments.
**EDIT:** I've deleted this list and integrated it into the first post to make things easier to find and track.
> Concerning `TrivialSector`, I understand you want to delete it. From my perspective, I have a use case for a `TrivialSector` in `FusionTensors`. There, I need a placeholder for the...
In a follow-up to my comment about maybe renaming `AbstractCategory` to `AbstractSector`, we should also consider renaming `CategoryProduct` to `SectorProduct` or something similar, since it is really a product of...
In `TensorKit.jl`, they use the names: - [`Sector`](https://github.com/QuantumKitHub/TensorKitSectors.jl/blob/v0.1.0/src/sectors.jl) for the abstract supertype that is analogous to what we now call `AbstractCategory` and what I'm proposing to change to `AbstractSector`, -...
@ogauthe I think you forgot to upload `trivial.jl`.