mtconnect-agent icon indicating copy to clipboard operation
mtconnect-agent copied to clipboard

Current agent buffer size is 2^17, should be similar size

Open wsobel opened this issue 8 years ago • 4 comments

We need to make the buffer size at least 32k by default to allow for adequate space in the circular buffer. We need to test the amount of memory this takes for initial configuration.

The current default size of 10 is far too small.

wsobel avatar Mar 08 '17 02:03 wsobel

The tests rely on the buffer size being 10, we need to have the tests set this explicitly.

wsobel avatar Mar 08 '17 03:03 wsobel

Priority 2

wsobel avatar Apr 07 '17 20:04 wsobel

@wsobel So there are few plces where this is used https://github.com/mtconnect/mtconnect-agent/blob/2e0508af679222998a53526c183ba851d89c1c22/src/dataStorage.js#L30 Which should be what size? https://github.com/mtconnect/mtconnect-agent/blob/2e0508af679222998a53526c183ba851d89c1c22/src/dataStorage.js#L37

andrewshatnyy avatar Apr 21 '17 02:04 andrewshatnyy

lokijs is not handling 32k record insertion well. Just found that https://github.com/mtconnect/mtconnect-agent/blob/2e0508af679222998a53526c183ba851d89c1c22/src/jsonToXML.js has both buffer values hardcoded

andrewshatnyy avatar Apr 21 '17 03:04 andrewshatnyy