api-platform-ms-bundle icon indicating copy to clipboard operation
api-platform-ms-bundle copied to clipboard

feat: add php8 typehints, update composer and GitHub actions

Open Chris53897 opened this issue 3 years ago • 1 comments

Hi, WIP One Test fails. I guess another Exception is Raised after TypeHints are added. I tried InvalidArgumentException but that was not working. Maybe you have an idea to solve this. Or if this test is still neccessary, yet after adding the TypeHints.

I have not much knowledge about Psalm. I will fix Codeing Standards later. I have some problems with Line Endings, and running locally needs manual adjustments for me. Update: https://github.com/mtarld/api-platform-ms-bundle/pull/79

I noticed that "psalm/plugin-phpunit": "^0.15", will not upgrade with composer update "psalm/plugin-phpunit": "^0.16", So i set this manually.

Greetz

Chris53897 avatar Jan 07 '22 19:01 Chris53897

PhpUnit Tests are running fine lokal (mac intel) with PHP 8.0.14 and 8.1.1. But GitHub Actions are failing. I did not figured out why.

Chris53897 avatar Jan 11 '22 11:01 Chris53897

Closed in favor of https://github.com/mtarld/api-platform-ms-bundle/pull/82, thank you, @Chris53897 :slightly_smiling_face:

mtarld avatar Apr 05 '23 14:04 mtarld