dropwizard-hikaricp icon indicating copy to clipboard operation
dropwizard-hikaricp copied to clipboard

Published 20 hours ago • verified publisher icon mtakaki

connectionTimeout

Open ravisaluru opened this issue 5 years ago • 6 comments
trafficstars

I have been looking at the various permutations to set the connectionTimeout value for the hikariConfig. There is no way in the present code it picks the value from the properties. The value always defaults to 30000.

ravisaluru avatar Feb 03 '20 20:02 ravisaluru

You're right, @ravisaluru! It looks like I missed this value. I've created the PR #9 and bumping some dependencies too.

mtakaki avatar Feb 06 '20 03:02 mtakaki

This is fixed on 2.0.1 and I'll port this fix into the other releases too.

mtakaki avatar Feb 08 '20 05:02 mtakaki

This is also fixed on 1.3.18. I'm closing this ticket, but please feel free to reopen if you are still seeing some issue.

mtakaki avatar Feb 08 '20 16:02 mtakaki

I would like to point out, basically, all the parameters which are mentioned as properties in the dropwizard YAML config aren't propagated as well. maybe look into the properties of the list Properties and set the related values? All these settings aren't really propagated to the Hikari datasource.

ravisaluru avatar Feb 12 '20 15:02 ravisaluru

Oh really? In this case it's a big deal and it should be fixed. I'll re-open this issue then.

mtakaki avatar Feb 25 '20 05:02 mtakaki

Can I please push the change, I know the exact code we need to change to make the changes.

All we need to do is change the code here, from

final HikariConfig config = new HikariConfig();
config.setDataSourceProperties(properties);

to

final HikariConfig config = new HikariConfig(properties);

By doing this, the properties which are being passed during the config are correctly set.

ravisaluru avatar Nov 25 '22 20:11 ravisaluru