msys2-runtime icon indicating copy to clipboard operation
msys2-runtime copied to clipboard

Default to enable_pcon

Open lazka opened this issue 2 years ago • 2 comments

We initially said that we'll enable it once there is a cygwin release without conpty fixes, but that hasn't happened.

Still it would be nice to have all those console using apps to just work by default.

@dscho could we try switching the default in this repo, or should we do it in a downstream patch first?

lazka avatar Jul 26 '22 05:07 lazka

@dscho could we try switching the default in this repo, or should we do it in a downstream patch first?

Let's do it here, by dropping (reverting) https://github.com/msys2/msys2-runtime/commit/b74f834aa69dc0b188d1b971fbd2014f5f4593bc

dscho avatar Jul 26 '22 13:07 dscho

ok, thanks. I'll enable it in the MSYS2 packaging CIs first to make sure it doesn't break anything package building related.

lazka avatar Jul 26 '22 15:07 lazka

I'll enable it in the MSYS2 packaging CIs first to make sure it doesn't break anything package building related.

I didn't see any issues there.

So next is the update to 3.3.6, and after that has settled I'll try switching on pcon.

lazka avatar Sep 06 '22 16:09 lazka

I'll enable it in the MSYS2 packaging CIs first to make sure it doesn't break anything package building related.

I didn't see any issues there.

So next is the update to 3.3.6, and after that has settled I'll try switching on pcon.

Sounds good to me!

dscho avatar Sep 07 '22 09:09 dscho

done in #102

lazka avatar Sep 20 '22 19:09 lazka