msys2-runtime
msys2-runtime copied to clipboard
fix(error message): Clarify magic number mismatch error message between heap child information
msys2 is a fork of cygwin but the error message for magic_versions is cygwin specific. Removing this message may remove a lot of documentation for users searching online.
However, the documentation itself is not useful. Users will not find a cygwin version nor does the help online specify exact information. While cygwin was intended to be installed at a single location, msys2 is used in a variety of stand alone tools, one of which is git-for-windows. Whenever a version mismatch can occur this can lead to programs such as VS Code breaking other git installations, or vice-versa. In this regard a bit of a better error message can help people figure out what is wrong on their msys2 or cygwin installed codebases.
Docs PR: https://github.com/msys2/msys2.github.io/pull/235
Sorry if this PR doesn't follow guidelines or should be submitted in another way. I couldn't find any documentation on this approach. Feel free to ignore if this isn't super useful, this is a tricky topic.
Ok, I've updated this with more links as well as more verbose documentation about what cygwin recommends, versus what msys2 runtime may support.
@lazka how do we want to proceed with regards to v3.4.2?
@lazka how do we want to proceed with regards to v3.4.2?
I've been testing it for the last few days and I'm not aware of any issues. I'll prepare a PR. edit: https://github.com/msys2/MSYS2-packages/pull/3409
@lazka how do we want to proceed with regards to v3.4.2?
we found another regression: https://cygwin.com/pipermail/cygwin/2022-December/252699.html