MSYS2-packages icon indicating copy to clipboard operation
MSYS2-packages copied to clipboard

PATCH: coreutils: fix md5sum --text option

Open pixelb opened this issue 1 month ago • 7 comments

Please apply the following change from upstream coreutils: https://github.com/coreutils/coreutils/commit/6f265b515e5b93cef9bef0c4994622574c55a1ba

pixelb avatar Nov 12 '25 18:11 pixelb

I tried to update to 9.8+, and aborted. Because current package is already nightmare mixing upstreamed patches and non upstreamed patches: https://github.com/msys2/MSYS2-packages/tree/master/coreutils. Would you look at those patches at upstream and help closing #3105?

oech3 avatar Nov 15 '25 17:11 oech3

How did you debug --text if there is no Windows binary yet? (I don't use WSL btw).

oech3 avatar Dec 14 '25 15:12 oech3

How did you debug --text if there is no Windows binary yet? (I don't use WSL btw).

I didn't debug it, but it seems correct as per the MSYS docsd

pixelb avatar Dec 15 '25 13:12 pixelb

8.32 does not have src/digest.c: https://github.com/coreutils/coreutils/tree/v8.32/src . So cherry-pick is impossible.

oech3 avatar Dec 16 '25 07:12 oech3

@lazka How about pushing coreutils99 subset as different pkg?

oech3 avatar Dec 16 '25 07:12 oech3

Well it's just a single line change. Attached the adjusted patch here... md5sum--text.patch

pixelb avatar Dec 16 '25 10:12 pixelb

https://github.com/msys2/MSYS2-packages/actions/runs/20266195623/artifacts/4884367837 I can't access to Windows now.

Thankyou! I'm not sure about PKGBUILD itself's license. So referenced the .patch instead of hosting. Also I'm highly doubting that this is included to MSYS package. Because not useful (current usecase is https://github.com/uutils/coreutils/issues/9168 only ...).

cc @RenjiSann

oech3 avatar Dec 16 '25 11:12 oech3

I closed a PR for backporting since no one can test it.

oech3 avatar Dec 18 '25 17:12 oech3