MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

new: mariadb-clients

Open Kreijstal opened this issue 1 month ago • 3 comments

Adding support for this, some workarounds were taken in order to compile with mingw but we finally have mysqldump as well.

couldn't build it for clang

Kreijstal avatar Nov 13 '25 07:11 Kreijstal

Nice! :+1:

Just out of curiosity: Is the huge patch file based on some existing code/issue/pull request? I'm asking because it contains a comment referring to "CONC-789", which is the ID of a ticket on MariaDB's Jira instance (https://jira.mariadb.org/browse/CONC-789). And such a big patch file (almost 1700 lines) would be quite a nightmare to maintain, because it will likely need to be refreshed on every update.

striezel avatar Nov 14 '25 06:11 striezel

Nice! 👍

Just out of curiosity: Is the huge patch file based on some existing code/issue/pull request? I'm asking because it contains a comment referring to "CONC-789", which is the ID of a ticket on MariaDB's Jira instance (https://jira.mariadb.org/browse/CONC-789). And such a big patch file (almost 1700 lines) would be quite a nightmare to maintain, because it will likely need to be refreshed on every update.

I didn't think I'd bother, since I didn't believe anyone at mariadb cares about compiling with mingw, if that is the case I could prepare a more focused patch. however the process of rebasing shouldn't be too exhausting too mantain since it is mostly condition headers.

Kreijstal avatar Nov 14 '25 06:11 Kreijstal

Two things:

  • Has anyone had the chance to do some tests with the artifacts from the CI? For example, can one connect with mariadb.exe to a MariaDB instance and issue a few queries? Does the mariadb-dump.exe create a correct DB dump? And so on.
  • There is pkgrel=2 in the PKGBUILD, but it should start at 1.

striezel avatar Nov 20 '25 18:11 striezel