MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

emacs: depend on texinfo for proper info directory update upon install

Open oscarfv opened this issue 1 year ago • 1 comments

This completes the fix for issue #631

oscarfv avatar May 02 '24 11:05 oscarfv

Looks like the ucrt64 build timed out. Forcing a new check run...

oscarfv avatar May 03 '24 01:05 oscarfv

FYI, rebuilding this again under GCC 14 will probably fail: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70889

As well as #20879

cyrilarnould avatar May 12 '24 15:05 cyrilarnould

@cyrilarnould : do you plan to submit a PR for the workaround mentioned on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70889#25 ?

Otherwise I will.

Thanks to you and @lazka for analyzing the faulty gcc 14.1 build.

oscarfv avatar May 13 '24 19:05 oscarfv

I'm currently checking whether the PKGBUILD recipe works on my machine with the workaround :)

But feel free to integrate it into your PR, my suggestion would have been

diff --git a/mingw-w64-emacs/PKGBUILD b/mingw-w64-emacs/PKGBUILD
index 469d137ca..7c088c6bc 100644
--- a/mingw-w64-emacs/PKGBUILD
+++ b/mingw-w64-emacs/PKGBUILD
@@ -83,6 +83,9 @@ build() {
   CFLAGS=${CFLAGS//"-Wp,-D_FORTIFY_SOURCE=2"}
   # -foptimize-sibling-calls breaks native compilation (GCC 13.1)
   CFLAGS+=" -fno-optimize-sibling-calls"
+  # configure script can not deal with the warnings that were turned
+  # into errors in GCC 14
+  CFLAGS+=" -Wno-error=implicit-function-declaration"

   ../${_realname}-${pkgver}/configure \
     --prefix="${MINGW_PREFIX}" \

cyrilarnould avatar May 13 '24 19:05 cyrilarnould

Okay, PR updated, thanks @cyrilarnould .

The occasional CI build failure seems to be a timing issue either on emacs' build system or in the nativecomp machinery.

oscarfv avatar May 13 '24 19:05 oscarfv

Upstream has worked around the issue -Wno-error=implicit-function-declaration with a different patch:

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5216903ae6c3f91ebefb1152af40753f723cbc39

Maybe using this might be more appropriate?

If so, they've also integrated a workaround for the -fno-optimize-sibling-calls problem:

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=19c983ddedf083f82008472c13dfd08ec94b615f

cyrilarnould avatar May 19 '24 14:05 cyrilarnould

thanks, I've referenced the commits in 0d77e7c68b6698f40c45f88399eed1caaf59baf3, so we can drop the workarounds maybe on the next upstream release.

lazka avatar May 28 '24 18:05 lazka