evince: update to 46.0

[ognevny]

[ognevny]

what is https://github.com/msys2/MINGW-packages/actions/runs/8801506958/job/24155022720?pr=20712#step:11:4056?

[Biswa96]

what is https://github.com/msys2/MINGW-packages/actions/runs/8801506958/job/24155022720?pr=20712#step:11:4056?

The package has symlinks.

BTW, does this work in your setup?

[ognevny]

The package has symlinks.

BTW, does this work in your setup?

what do you mean? I didn't test it

[iahung4]

Does this PR fix these issues?

https://github.com/msys2/MINGW-packages/issues/19723 https://github.com/msys2/MINGW-packages/issues/20537

p/s: I lost access to my @iahung3 account.

[ognevny]

Does this PR fix these issues?

https://github.com/msys2/MINGW-packages/issues/19723 https://github.com/msys2/MINGW-packages/issues/20537

p/s: I lost access to my @iahung3 account.

currently I can't check this. you can download the package from artifacts

[iahung4]

Does this PR fix these issues? #19723 #20537 p/s: I lost access to my @iahung3 account.

currently I can't check this. you can download the package from artifacts

The issues are still there.

[ghost]

@ognevny Can you fix these issues?

p/s: I'm back.

[ognevny]

@ognevny Can you fix these issues?

p/s: I'm back.

I'm on vacation until the 5th on May, I don't have access to the pc, sorry

[ognevny]

@ognevny Can you fix these issues?

p/s: I'm back.

I didn't find any file for icon/manifest. -mwindows is already used as link flag: https://gitlab.gnome.org/GNOME/evince/-/blob/main/meson.build?ref_type=heads#L109

[ognevny]

pushed an update to 46.3

[hmartinez82]

@iahung3 The missing icon is an upstream issue. I'll try to get them an icon soon.

[hmartinez82]

@iahung3 https://gitlab.gnome.org/GNOME/evince/-/merge_requests/701

[ognevny]

should I backport this change?

[hmartinez82]

That's up to you. It's just cosmetics at this point 😅. And it's not only text, you'd also have to add the .ico file to the patch.

[ognevny]

That's up to you. It's just cosmetics at this point 😅. And it's not only text, you'd also have to add the .ico file to the patch.

I guess the binary form will be installed in patch file. let's give it a try

[ognevny]

@hmartinez82 what does this mean?

FAILED: shell/shell_evince.rc_evince.o
"C:\msys64\clang64\bin/windres.EXE" "../evince-46.3/shell/evince.rc" "shell/shell_evince.rc_evince.o" "--preprocessor-arg=-MD" "--preprocessor-arg=-MQshell/shell_evince.rc_evince.o" "--preprocessor-arg=-MFshell/shell_evince.rc_evince.o.d"
llvm-rc: Error in ICON statement (ID Icon):
Incorrect icon/cursor Reserved field; should be 0.

[hmartinez82]

Oh I guess I should try with Clang, I only tried UCRT64 @ognevny I'll have to look at it myself. I don't know what this means just by looking at that. Clearly, LLVM's windres is not happy.

[hmartinez82]

@ognevny I just built it with the icon using the CLANG64 environment. Not only I don't see your error, it does create evince.exe with the icon correctly:

[ognevny]

in recipe I copied the ico (I downloaded it separately) with cp -a ${srcdir}/evince.ico shell. is the path correct?

[ognevny]

in UCRT64 I get C:\msys64\ucrt64\bin/windres.EXE: icon file `./../evince-46.3/shell/evince.ico' does not contain icon data

[hmartinez82]

The new files should be shell/evince.rc shell/evince.ico and there are changes to shell/meson.build

[ognevny]

The new files should be shell/evince.rc shell/evince.ico and there are changes to shell/meson.build

I download the patch, but removed .ico file from there. I download it separately from https://gitlab.gnome.org/GNOME/evince/-/blob/24967ecf7f658bb69e512d6e09287c1ccc02c11c/shell/evince.ico

[hmartinez82]

in UCRT64 I get C:\msys64\ucrt64\bin/windres.EXE: icon file `./../evince-46.3/shell/evince.ico' does not contain icon data

Then you are definitely missing a file. Look at the original PR. There are three things

[ognevny]

in UCRT64 I get C:\msys64\ucrt64\bin/windres.EXE: icon file `./../evince-46.3/shell/evince.ico' does not contain icon data

Then you are definitely missing a file. Look at the original PR. There are three things

it was a surprise for me, but downloading with that url from source is incorrect. it works after I download the with download button 🤦‍♂️

[ognevny]

I guess I can't push it

[hmartinez82]

I'd say go ahead and merge this, then I'll take a look into the icon in a separate PR

[hmartinez82]

@ognevny I created this PR into this PR's branch branch https://github.com/ognevny/MINGW-packages/pull/5

[ognevny]

@ognevny I created this PR into this PR's branch branch https://github.com/ognevny/MINGW-packages/pull/5

what inline=false do?

[hmartinez82]

@ognevny I created this PR into this PR's branch branch ognevny#5

what inline=false do?

I didn't ask 😅 That's the link to download the file from the Merge Request, untouched. I did not create that link myself. That url is the unmodified url you get for downloading:

[ognevny]

@ognevny I created this PR into this PR's branch branch ognevny#5

what inline=false do?

I didn't ask 😅 That's the link to download the file from the Merge Request, untouched. I did not create that link myself. That url is the unmodified url you get for downloading:

understood...