MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

luarocks: update to 3.11.1

Open sewbacca opened this issue 1 year ago • 5 comments

This PR updates luarocks to version 3.11.0 (resolves #20323). Fixes some inconsistencies in the patch file. Removes patches for spec/util/test_env.lua as they also caused the patch to fail and are for testing purposes only. Is it required to patch the test environment? I can adjust the patch if necessary.

sewbacca avatar Mar 27 '24 14:03 sewbacca

Removes patches for spec/util/test_env.lua as they also caused the patch to fail and are for testing purposes only.

If that patch fixes issue with testing I would recommend to keep that.

Biswa96 avatar Mar 27 '24 14:03 Biswa96

I still had to remove this section:

@@ -429,7 +431,9 @@
       return execute_output("find " .. path .. " -type f -exec stat -f \"%z %N\" {} \\; | md5")
    elseif test_env.TEST_TARGET_OS == "windows" then
       return execute_output("\"" .. Q(test_env.testing_paths.win_tools .. "/find") .. " " .. Q(path)
-         .. " -printf \"%s %p\"\" > temp_sum.txt && certUtil -hashfile temp_sum.txt && del temp_sum.txt")
+         .. " -printf \"%s %p\"\" > temp_sum.txt && "
+         .. "C:\\Windows\\System32\\certUtil -hashfile temp_sum.txt && "
+		 .. "del temp_sum.txt")
    end
 end

as the function definition to which it relates to appears to be removed.

sewbacca avatar Mar 27 '24 15:03 sewbacca

What is the rationale for keeping tests? The affected file won't be shipped (checked with pacman -Ql mingw-w64-ucrt-x86_64-lua-luarocks | grep test_env.lua).

sewbacca avatar Mar 27 '24 15:03 sewbacca

What is the rationale for keeping tests?

Some maintainers run those tests in their machine. I can not tell if anyone has run tests in this case.

Biswa96 avatar Mar 27 '24 16:03 Biswa96