MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

lua-lpeg, lua51-lsqlite3, lua51-winapi require pkgconf as build dependency

Open FractalU opened this issue 11 months ago • 2 comments

Description / Steps to reproduce the issue

I noticed that the packages lua-lpeg, lua51-lsqlite3 and lua51-winapi run the pkg-config command when building them, yet pkgconf isn't specified in their build dependencies. I guess it's a bug and not intended. The packages lua51-bitop, lua-mpack that also run pkg-config when building them do have pkgconf specified in their build dependencies. For lua-lpeg, it's clear that pkg-config is being invoked in PKGBUILD. However, for lua51-lsqlite3 and lua51-winapi, it's not easy to spot that those packages require pkgconf. pkg-config is being invoked in Makefile.mingw, not PKGBUILD.

Expected behavior

In PKGBUILD of the packages lua-lpeg, lua51-lsqlite3 and lua51-winapi add ${MINGW_PACKAGE_PREFIX}-pkgconf to makedepends.

Actual behavior

${MINGW_PACKAGE_PREFIX}-pkgconf is not specified in the build dependencies of lua-lpeg, lua51-lsqlite3 and lua51-winapi.

Verification

  • [X] I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MINGW64_NT-10.0-22621

MINGW environments affected

  • [X] MINGW64
  • [X] MINGW32
  • [X] UCRT64
  • [X] CLANG64
  • [X] CLANG32
  • [X] CLANGARM64

Are you willing to submit a PR?

no

FractalU avatar Mar 13 '24 18:03 FractalU

It uses the msys pkgconf package which is part of base-devel group. Adding mingw pkgconf in makedepends does not change the package in any way.

Biswa96 avatar Mar 13 '24 19:03 Biswa96

@Biswa96 For me, it would be nice if the packages are consistent with this. Currently, some of the packages have pkgconf as their build dependency while others don't. To me, this looks like a mess. Perhaps, can pkgconf be removed from the build dependencies of all the packages if it's already part of base-devel? Or is it better to leave things as they are?

FractalU avatar Mar 13 '24 19:03 FractalU