MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

qt6-webengine

Open raedrizqie opened this issue 1 year ago • 17 comments

raedrizqie avatar Aug 09 '23 13:08 raedrizqie

@lazka need your help here.. how can we correctly invoke node.exe through winpty , or just using the node shell script in subprocess.run or subprocess.Popen ?

the error msg:

2023-08-10T02:48:26.8254094Z Traceback (most recent call last):
2023-08-10T02:48:26.8427172Z   File "C:/_/B/src/qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/node/node.py", line 69, in <module>
2023-08-10T02:48:26.8427909Z     RunNode(sys.argv[1:])
2023-08-10T02:48:26.8428706Z   File "C:/_/B/src/qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/node/node.py", line 45, in RunNode
2023-08-10T02:48:26.8429224Z     process = subprocess.run(
2023-08-10T02:48:26.8429543Z               ^^^^^^^^^^^^^^^
2023-08-10T02:48:26.8429897Z   File "D:/M/msys64/clang64/lib/python3.11/subprocess.py", line 571, in run
2023-08-10T02:48:26.8430364Z     raise CalledProcessError(retcode, process.args,
2023-08-10T02:48:26.8431832Z subprocess.CalledProcessError: Command '['/usr/bin/winpty node.exe', '../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/devtools-frontend/src/scripts/build/ninja/copy-files.js', '../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/devtools-frontend/src/extension-api', 'gen/third_party/devtools-frontend/src/extension-api', 'ExtensionAPI.d.ts,extension-api-tsconfig.json']' returned non-zero exit status 1.

raedrizqie avatar Aug 10 '23 07:08 raedrizqie

@Biswa96

2023-08-27T17:19:58.7096300Z [19478/27307] CXX obj/media/audio/audio/core_audio_util_win.o
2023-08-27T17:19:58.7102696Z FAILED: obj/media/audio/audio/core_audio_util_win.o 
2023-08-27T17:19:58.7782566Z clang++  -MMD -MF obj/media/audio/audio/core_audio_util_win.o.d -DUSE_AURA=1 -DOFFICIAL_BUILD -DTOOLKIT_QT -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_FE -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DIS_MEDIA_IMPL -DUSE_EGL -DLIBYUV_DISABLE_NEON -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED "-DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\"" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_HAS_WUFFS_LIBRARY -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -Igen -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/khronos -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/gpu -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/libyuv/include -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/abseil-cpp -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/boringssl/src/include -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/protobuf/src -Igen/protoc_out -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/skia -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/wuffs/src/release/c -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/mesa_headers -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wthread-safety -Wno-array-parameter -Wno-attributes -Wno-format -Wno-missing-braces -Wno-parentheses -Wno-sign-compare -Wno-unknown-pragmas -Wno-deprecated-builtins -Wno-deprecated-declarations -Wno-macro-redefined -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-nonportable-include-path -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -Wno-unknown-argument -Wno-unknown-attributes -Wno-unknown-warning-option -Wno-predefined-identifier-outside-function -Wno-unknown-pragmas -Wno-address -Wno-parentheses -Wno-sign-compare -Wno-stringop-overflow -Wno-stringop-overread -Wno-psabi -Wno-multichar -Wno-format-zero-length -fcolor-diagnostics -fmerge-all-constants -fcomplete-member-pointers -no-canonical-prefixes -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fomit-frame-pointer -gdwarf-4 -g1 -gdwarf-aranges -fcf-protection=full -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -DPROTOBUF_ALLOW_DEPRECATED=1 -ID:/M/msys64/clang64/include/opus -Wno-pessimizing-move -Wno-return-type -Wno-shadow -Wno-return-type -Wno-parentheses-equality -Wno-tautological-compare -Wno-thread-safety-attributes -Wno-deprecated-copy -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++17 -Wno-trigraphs -fno-rtti -c ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/audio/win/core_audio_util_win.cc -o obj/media/audio/audio/core_audio_util_win.o
2023-08-27T17:19:58.8643399Z In file included from ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/audio/win/core_audio_util_win.cc:30:
2023-08-27T17:19:58.9323455Z In file included from ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/base/win/mf_helpers.h:10:
2023-08-27T17:19:58.9820004Z D:/M/msys64/clang64/include/ddraw.h:773:16: error: redefinition of '_DDPIXELFORMAT'
2023-08-27T17:19:59.1245432Z typedef struct _DDPIXELFORMAT {
2023-08-27T17:19:59.1849365Z                ^
2023-08-27T17:19:59.3257460Z D:/M/msys64/clang64/include/ksmedia.h:4260:16: note: previous definition is here
2023-08-27T17:19:59.3882972Z typedef struct _DDPIXELFORMAT
2023-08-27T17:19:59.4075633Z                ^
2023-08-27T17:19:59.4268726Z In file included from ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/audio/win/core_audio_util_win.cc:30:
2023-08-27T17:19:59.4272465Z 
2023-08-27T17:19:59.4273552Z In file included from ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/base/win/mf_helpers.h:11:
2023-08-27T17:19:59.4274120Z 
2023-08-27T17:19:59.4274730Z D:/M/msys64/clang64/include/strmif.h:12304:18: error: redefinition of 'tagTIMECODE_SAMPLE'
2023-08-27T17:19:59.4275218Z 
2023-08-27T17:19:59.4275572Z   typedef struct tagTIMECODE_SAMPLE {
2023-08-27T17:19:59.4275963Z 
2023-08-27T17:19:59.4276239Z                  ^
2023-08-27T17:19:59.4276577Z 
2023-08-27T17:19:59.4277017Z D:/M/msys64/clang64/include/ksmedia.h:3851:16: note: previous definition is here
2023-08-27T17:19:59.4277469Z 
2023-08-27T17:19:59.4277808Z typedef struct tagTIMECODE_SAMPLE {
2023-08-27T17:19:59.4278191Z 
2023-08-27T17:19:59.4278471Z                ^
2023-08-27T17:19:59.4278793Z 
2023-08-27T17:19:59.4279088Z 2 errors generated.

conflicting definitions between ksmedia.h with ddraw.h and strmif.h maybe this is a mingw-w64 header bug?

raedrizqie avatar Aug 29 '23 09:08 raedrizqie

in strmif.h:

#ifndef TIMECODE_DEFINED
#define TIMECODE_DEFINED
  typedef union _timecode {
    __C89_NAMELESS struct {
      WORD wFrameRate;
      WORD wFrameFract;
      DWORD dwFrames;
    };
    DWORDLONG qw;
  } TIMECODE;
#endif

  typedef TIMECODE *PTIMECODE;

  typedef struct tagTIMECODE_SAMPLE {
    LONGLONG qwTick;
    TIMECODE timecode;
    DWORD dwUser;
    DWORD dwFlags;
  } TIMECODE_SAMPLE;

  typedef TIMECODE_SAMPLE *PTIMECODE_SAMPLE;

in ksmedia.h:

#ifndef TIMECODE_DEFINED
#define TIMECODE_DEFINED
typedef union _timecode {
  struct {
    WORD wFrameRate;
    WORD wFrameFract;
    DWORD dwFrames;
  };
  DWORDLONG qw;
} TIMECODE;
typedef TIMECODE *PTIMECODE;

typedef struct tagTIMECODE_SAMPLE {
  LONGLONG qwTick;
  TIMECODE timecode;
  DWORD dwUser;
  DWORD dwFlags;
} TIMECODE_SAMPLE;

typedef TIMECODE_SAMPLE *PTIMECODE_SAMPLE;
#endif /* TIMECODE_DEFINED */

the TIMECODE_DEFINED guard is inconsistent

raedrizqie avatar Aug 29 '23 12:08 raedrizqie

Patch sent https://sourceforge.net/p/mingw-w64/mailman/message/37889060/ https://sourceforge.net/p/mingw-w64/mailman/message/37889061/

But ddraw.h also needs the same fix and it is imported from wine.

Biswa96 avatar Aug 29 '23 15:08 Biswa96

conflicting definitions between ksmedia.h with ddraw.h and strmif.h maybe this is a mingw-w64 header bug?

That issue have been fixed in the following mingw-w64 commits.

  • https://sourceforge.net/p/mingw-w64/mingw-w64/ci/93aa9727c7f05dc1a7fd0e14b1ec9b318cf3625d/
  • https://sourceforge.net/p/mingw-w64/mingw-w64/ci/c26039d0b1a34ee412075b7d6770148546a23142/
  • https://sourceforge.net/p/mingw-w64/mingw-w64/ci/79d2573fbfb7ed35d5ae3a05077adc2b1866683a/

Biswa96 avatar Aug 31 '23 04:08 Biswa96

Seems the builds cannot find bthledef.h but it looks like it was added recently: https://sourceforge.net/p/mingw-w64/mingw-w64/ci/3fc5347bb34720b95112f5d2f6180ee3976ea3a5/

adrpo avatar Aug 31 '23 18:08 adrpo

Seems the builds cannot find bthledef.h but it looks like it was added recently

Yes, but it is not complete yet. We are discussing the build issues constantly.

Biswa96 avatar Aug 31 '23 18:08 Biswa96

Good to know. Where are these discussions? Maybe I can help with some things.

adrpo avatar Aug 31 '23 18:08 adrpo

Where are these discussions?

In private discord DM.

Biswa96 avatar Aug 31 '23 18:08 Biswa96

those winrt errors are expected since mingw-w64 have incomplete implementations for winrt headers.. my latest patches try to disable any winrt related codes..

raedrizqie avatar Sep 05 '23 09:09 raedrizqie

2023-09-05T16:52:24.6212297Z [20809/27287] CXX obj/media/gpu/gpu/dxva_video_decode_accelerator_win.o
2023-09-05T16:52:24.6524660Z FAILED: obj/media/gpu/gpu/dxva_video_decode_accelerator_win.o 
2023-09-05T16:52:24.8270745Z clang++  -MMD -MF obj/media/gpu/gpu/dxva_video_decode_accelerator_win.o.d -DMEDIA_GPU_IMPLEMENTATION -DUSE_AURA=1 -DOFFICIAL_BUILD -DTOOLKIT_QT -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_FE -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DLIBYUV_DISABLE_NEON -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED "-DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\"" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_HAS_WUFFS_LIBRARY -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DLIBGAV1_MAX_BITDEPTH=10 -DLIBGAV1_THREADPOOL_USE_STD_MUTEX -DLIBGAV1_ENABLE_LOGGING=0 -DLIBGAV1_PUBLIC= -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DLEVELDB_PLATFORM_CHROMIUM=1 -Igen -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/khronos -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/gpu -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/libyuv/include -Igen/third_party/dawn/include -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/dawn/include -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/abseil-cpp -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/boringssl/src/include -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/protobuf/src -Igen/protoc_out -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/skia -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/wuffs/src/release/c -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/ced/src -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/mesa_headers -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/libgav1/src -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/libgav1/src/src -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/libwebm/source -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/leveldatabase -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/leveldatabase/src -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/leveldatabase/src/include -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/libaom/source/libaom -I../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/third_party/angle/include -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wthread-safety -Wno-array-parameter -Wno-attributes -Wno-format -Wno-missing-braces -Wno-parentheses -Wno-sign-compare -Wno-unknown-pragmas -Wno-deprecated-builtins -Wno-deprecated-declarations -Wno-macro-redefined -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-nonportable-include-path -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -Wno-unknown-argument -Wno-unknown-attributes -Wno-unknown-warning-option -Wno-predefined-identifier-outside-function -Wno-unknown-pragmas -Wno-address -Wno-parentheses -Wno-sign-compare -Wno-stringop-overflow -Wno-stringop-overread -Wno-psabi -Wno-multichar -Wno-format-zero-length -fcolor-diagnostics -fansi-escape-codes -fmerge-all-constants -fcomplete-member-pointers -no-canonical-prefixes -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fomit-frame-pointer -gdwarf-4 -g1 -gdwarf-aranges -fcf-protection=full -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 -Wno-pessimizing-move -Wno-return-type -Wno-shadow -Wno-return-type -Wno-parentheses-equality -Wno-tautological-compare -Wno-thread-safety-attributes -Wno-deprecated-copy -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++17 -Wno-trigraphs -fno-rtti -c ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/gpu/windows/dxva_video_decode_accelerator_win.cc -o obj/media/gpu/gpu/dxva_video_decode_accelerator_win.o
2023-09-05T16:52:24.8280667Z ../../../../../qtwebengine-everywhere-src-6.5.2/src/3rdparty/chromium/media/gpu/windows/dxva_video_decode_accelerator_win.cc:100:13: error: redefinition of 'CLSID_VideoProcessorMFT'
2023-09-05T16:52:24.8560777Z DEFINE_GUID(CLSID_VideoProcessorMFT,
2023-09-05T16:52:25.0287504Z             ^
2023-09-05T16:52:25.0594271Z D:/M/msys64/clang64/include/mfidl.h:7420:13: note: previous definition is here
2023-09-05T16:52:27.1220716Z EXTERN_GUID(CLSID_VideoProcessorMFT, 0x88753b26, 0x5b24, 0x49bd, 0xb2, 0xe7, 0xc, 0x44, 0x5c, 0x78, 0xc9, 0x82);
2023-09-05T16:52:27.1222507Z 
2023-09-05T16:52:27.1222793Z             ^
2023-09-05T16:52:27.1223094Z 
2023-09-05T16:52:27.1223369Z 1 error generated.

from dxva_video_decode_accelerator_win.cc:

#if VER_PRODUCTBUILD < 10011  // VER_PRODUCTBUILD for 10.0.10158.0 SDK.
DEFINE_GUID(CLSID_VideoProcessorMFT,
            0x88753b26,
            0x5b24,
            0x49bd,
            0xb2,
            0xe7,
            0xc,
            0x44,
            0x5c,
            0x78,
            0xc9,
            0x82);
#endif

@Biswa96 should mfidl.h have the same guard? we can also just guard this with _MSC_VER though

raedrizqie avatar Sep 05 '23 17:09 raedrizqie

should mfidl.h have the same guard?

No. VER_PRODUCTBUILD is not used in any header file. Instead, the macro in dxva_video_decode_accelerator_win.cc should be checked using #if defined(VER_PRODUCTBUILD) && VER_PRODUCTBUILD < 10011

Biswa96 avatar Sep 05 '23 17:09 Biswa96

should mfidl.h have the same guard?

No. VER_PRODUCTBUILD is not used in any header file. Instead, the macro in dxva_video_decode_accelerator_win.cc should be checked using #if defined(VER_PRODUCTBUILD) && VER_PRODUCTBUILD < 10011

this still fails because VER_PRODUCTBUILD is lower in ntverp.h

#define VER_PRODUCTBUILD 3790

raedrizqie avatar Sep 06 '23 09:09 raedrizqie

this still fails because VER_PRODUCTBUILD is lower in ntverp.h

Then disabling it with _MSC_VER is the only choice here. I am not sure if ntverp.h in mingw-w64 should be updated with Windows 10 version numbers.

Biswa96 avatar Sep 06 '23 13:09 Biswa96

hits timeout

raedrizqie avatar Oct 04 '23 07:10 raedrizqie

any progress?

ognevny avatar Nov 16 '23 11:11 ognevny

interested

Kreijstal avatar Apr 14 '24 16:04 Kreijstal