MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

gcc: Enable <stacktrace>

Open HazardyKnusperkeks opened this issue 2 years ago • 15 comments

Fixes #14082.

HazardyKnusperkeks avatar Dec 11 '22 21:12 HazardyKnusperkeks

I'll try to get the patches into upstream.

HazardyKnusperkeks avatar Dec 11 '22 21:12 HazardyKnusperkeks

So what is the error here? Shouldn't MPC be a dependency already? How did you update gcc before?

HazardyKnusperkeks avatar Dec 11 '22 21:12 HazardyKnusperkeks

hm, could be gcc version checking failing somehow. I updated mpc yesterday

edit:

In file included from conftest.c:10:
C:/msys64/ucrt64/include/mpc.h:287:35: error: unknown type name 'FILE'
  287 | __MPC_DECLSPEC void mpcr_out_str (FILE *f, mpcr_srcptr r);
      |                                   ^~~~
C:/msys64/ucrt64/include/mpc.h:27:1: note: 'FILE' is defined in header '<stdio.h>'; did you forget to '#include <stdio.h>'?
   26 | #include "mpfr.h"
   27 | 

sorry for the bad timing :/ see #14566

lazka avatar Dec 11 '22 21:12 lazka

So, is this good?

HazardyKnusperkeks avatar Dec 13 '22 22:12 HazardyKnusperkeks

I don't think we have any GCC/libbacktrace developers here, so this is hard/impossible to judge.

Upstream development happens here afaik: https://github.com/ianlancetaylor/libbacktrace

lazka avatar Dec 14 '22 20:12 lazka

I can tell you: it works. ;)

So I have to wait to get the patches accepted upstream?

HazardyKnusperkeks avatar Dec 15 '22 19:12 HazardyKnusperkeks

I can tell you: it works. ;)

I believe you, but I can tell you that I'm not going to spend extra time maintaining it, rebasing it, debugging it, etc ;)

So I have to wait to get the patches accepted upstream?

Yes, but we are happy to backport things, so they are available to users right away once upstream had a look.

lazka avatar Dec 15 '22 19:12 lazka

What's the status of this?

lazka avatar Mar 10 '23 09:03 lazka

What's the status of this?

The review process of gcc is really not my favorite, some patches are landed, some are outstanding. I just need to motivate myself to ask again.

HazardyKnusperkeks avatar Mar 19 '23 20:03 HazardyKnusperkeks

looks like stacktrace will be enabled in gcc 14

ognevny avatar May 03 '24 05:05 ognevny

Yes, and most of my patches are applied, but not all of them. When the last one has landed (for gcc 15) I'll update this PR, but I'll wait for GCC 14 to be released and my vacation to be over. ;)

HazardyKnusperkeks avatar May 03 '24 07:05 HazardyKnusperkeks

Yes, and most of my patches are applied, but not all of them. When the last one has landed (for gcc 15) I'll update this PR, but I'll wait for GCC 14 to be released and my vacation to be over. ;)

sounds good. maybe it will be nice to backport the patch after GCC 14 update is pushed

ognevny avatar May 03 '24 08:05 ognevny

This is the updated version, all patches except for the last one (tlhelp32 check in libstdc++) have been landed in upstream gcc and will be part of gcc 15. The last patch I'll send out later.

I've successfully tested it on UCTR64.

HazardyKnusperkeks avatar May 16 '24 18:05 HazardyKnusperkeks

The last commit was accepted upstream. Can we merge this @lazka ?

HazardyKnusperkeks avatar May 21 '24 18:05 HazardyKnusperkeks

I'll have a look, thanks

lazka avatar May 21 '24 19:05 lazka