MINGW-packages icon indicating copy to clipboard operation
MINGW-packages copied to clipboard

[new-package] nvc 1.8-devel-4efbf71

Open amb5l opened this issue 3 years ago • 2 comments

The NVC VHDL Compiler and Simulator.

amb5l avatar Oct 17 '22 16:10 amb5l

Please take a look at https://www.msys2.org/dev/new-package/, and Please fellow the template in https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-PKGBUILD-templates/PKGBUILD.autotools-tarball.sh

MehdiChinoune avatar Oct 17 '22 18:10 MehdiChinoune

Please add pkgver function. https://wiki.archlinux.org/title/VCS_package_guidelines

MehdiChinoune avatar Oct 18 '22 14:10 MehdiChinoune

Please pause this PR for now, testing of the built packages has revealed some problems. I will push a fix shortly.

amb5l avatar Oct 21 '22 13:10 amb5l

We now have a version that passes the important tests. This PR is a bit of a mess - 10+ commits - would you prefer me to close and try again, or submit a final commit to this PR?

amb5l avatar Oct 29 '22 19:10 amb5l

You could also squash your commits and force push to your branch to condense the commits in this PR.

mmuetzel avatar Oct 29 '22 19:10 mmuetzel

The latest run looks very strange, as if the wrong PKGBUILD was used. I will have another go at squashing commits.

amb5l avatar Oct 30 '22 13:10 amb5l

It doesn't look like squashing the commits in this PR worked. One way to manually squash your commits is:

  • Locally strip all your changes from this PR with git reset --soft bf014c6c5f4b9caae8ca99073f32b9550b44ca9b~1. That way all files will stay the same. But the local branch is back to where you started.
  • Optionally, fast-forward to a current head.
  • Commit your changes (in one single changeset or whatever number of incremental steps you prefer).
  • Force push the new state of your local branch to your remote branch.

Those steps worked for me in most of the cases.

mmuetzel avatar Oct 30 '22 14:10 mmuetzel

@mmuetzel thank you for your assistance. My fork now has a single commit.

amb5l avatar Oct 30 '22 14:10 amb5l

Hi all - please let me know if anything else is required for you to accept this PR.

amb5l avatar Nov 05 '22 17:11 amb5l