msw icon indicating copy to clipboard operation
msw copied to clipboard

Published 20 hours ago • verified publisher icon mswjs

feat: supports custom predicate as the "quiet" option value

Open balavishnuvj opened this issue 4 years ago • 5 comments

  • Closes #420

balavishnuvj avatar Oct 13 '20 18:10 balavishnuvj

@kettanaito @marcosvega91 please do let me know your concerns are not addressed.

balavishnuvj avatar Oct 15 '20 10:10 balavishnuvj

@kettanaito what needs to be done here? bit confused 😅

balavishnuvj avatar Dec 01 '20 12:12 balavishnuvj

looks like a simpler quiet: boolean was merged here. Not sure what the status of this is.

lukesmurray avatar Feb 10 '21 17:02 lukesmurray

@balavishnuvj, sorry, I've lost the context of these changes after a while. Worry not, I will check what's left to do, if anything, and update the review status. The issues/active collaborators ratio is rather high, so certain features although useful and awesome don't get as much attention as they deserve.

kettanaito avatar Feb 12 '21 23:02 kettanaito

@lukesmurray, hey 👋 You're right, you can already silence the logging by passing quiet: false to either worker.start() or server.listen(). This pull request aims for that quiet option to support a custom predicate, so you may choose which requests to log and which to ignore.

kettanaito avatar Feb 12 '21 23:02 kettanaito

Thanks once again for working on this, @balavishnuvj!

I think I will close this one. I can see this being a useful feature but it has a few cost points that don't quite justify the gain here. It's an additional config, and I'd like to be extremely strict when it comes to it. Moreover, this hasn't been requested as a missing feature for three years the pull request has been open.

I'd be glad to circle back on this if more people find this missing. Until then, closing.

kettanaito avatar Mar 17 '24 11:03 kettanaito