msw icon indicating copy to clipboard operation
msw copied to clipboard

chore: use vitest for type testing

Open KaiSpencer opened this issue 1 year ago • 4 comments

closes #2019

KaiSpencer avatar Feb 09 '24 18:02 KaiSpencer

Hey @kettanaito,

I have made a first stab at this. Would it be possible for you to approve the workflow run so I can see if what I have done for the vitest config RE typescript versions is even remotely correct :D

KaiSpencer avatar Feb 09 '24 18:02 KaiSpencer

@KaiSpencer, looks like some of your changes were reflected in the pnpm-lock.yaml. Could you please run pnpm install and commit the changes to the lockfile? That should unblock the CI. Thanks.

kettanaito avatar Feb 12 '24 10:02 kettanaito

@KaiSpencer, looks like some of your changes were reflected in the pnpm-lock.yaml. Could you please run pnpm install and commit the changes to the lockfile? That should unblock the CI. Thanks.

I have done this and committed the lockfile, so should be good to go again on CI now

KaiSpencer avatar Feb 12 '24 21:02 KaiSpencer

Hey @kettanaito I am happy with the type testing now. but there are some browser tests failing msw-api/setup-worker/life-cycle-events/on.test.ts

It seems the response.url is returning back as an empty string. Not quite sure why :D Any ideas?

KaiSpencer avatar Feb 14 '24 23:02 KaiSpencer

@KaiSpencer, that's an unrelated issue (I think #2031).

kettanaito avatar Mar 21 '24 11:03 kettanaito

You, sir, are incredible. Thank you for making this happen and welcome to contributors, @KaiSpencer 👏

kettanaito avatar Mar 21 '24 11:03 kettanaito

You, sir, are incredible. Thank you for making this happen and welcome to contributors, @KaiSpencer 👏

Thank you for the support throughout this, It was a nice Issue/PR to get my foot in the door 🙇‍♂️

KaiSpencer avatar Mar 21 '24 11:03 KaiSpencer

If you see any other tasks that interest you, don't hesitate to leave a comment!

kettanaito avatar Mar 21 '24 12:03 kettanaito

I'll take a look 👀

KaiSpencer avatar Mar 21 '24 12:03 KaiSpencer

Released: v2.2.10 🎉

This has been released in v2.2.10!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

kettanaito avatar Mar 22 '24 01:03 kettanaito