themecreator icon indicating copy to clipboard operation
themecreator copied to clipboard

Issues WIth MELPA Submission

Open SamuelBanya opened this issue 1 year ago • 1 comments

I am in pending status for the 'morrowind-emacs-theme' related theme I created with 'themecreator' on MELPA aka the Emacs based package site itself: https://github.com/melpa/melpa/pull/8095

These are the issues that were generated as a result of the 'themecreator' itself, but I'm not sure how I can fix this because this is as a result of 'themecreator' itself:

8 issues found:
1:0: error: Package should have a Homepage or URL header.
1:0: warning: The word "emacs" is redundant in Emacs package names.
26:0: error: Package should have a non-empty ;;; Commentary section.
250:8: warning: Closing parens should not be wrapped onto new lines.
266:3: warning: Closing parens should not be wrapped onto new lines.

Including this here in case anyone like myself wants to use this tool to make themes for MELPA, and wants to get approved.

Please let me know if there is anything within the 'themecreator' code base that could be revised accordingly, thanks.

SamuelBanya avatar Aug 02 '22 02:08 SamuelBanya

Hi, thank you for opening this issue.

You can find the emacs template in the templates folder here.

Please feel free to clone this repo, adapt the emacs template to fit with the current melpa package codestyle and send a pull request.

mswift42 avatar Aug 03 '22 17:08 mswift42

Closing this now because of a lack of response.

mswift42 avatar Mar 08 '23 07:03 mswift42

@mswift42 Please check the merge request here: https://github.com/mswift42/themecreator/pull/33

SamuelBanya avatar Mar 11 '23 21:03 SamuelBanya