Maciej Swiderski

Results 23 comments of Maciej Swiderski

here is a pull request to provide this enhancement https://github.com/Swagger2Markup/swagger2markup/pull/350

Thanks @AlanGreene for linking to this issue. One approach I was thinking about was to rely on already existing dashboard extension for custom task that could provide at least the...

> Last week I started working on some simple versions of the list + resource details pages for the Run resource. Initially this will be something similar to the PipelineResources...

> I'm not sure I fully understand the questions. Can you clarify / expand on them? In particular, what do you mean by 'extensions of custom tasks'? This is the...

> Ah I understand now, thanks. What does a Run resource look like for your approval task? I am running on the latest released version of the dashboard so don't...

thanks, will provide you that hopefully today and will also try the nightly build too!

So here it is ```` apiVersion: tekton.dev/v1alpha1 kind: Run metadata: annotations: kubectl.kubernetes.io/last-applied-configuration: | {"apiVersion":"tekton.dev/v1beta1","kind":"Pipeline","metadata":{"annotations":{},"name":"testpipeline2","namespace":"default"},"spec":{"tasks":[{"name":"deploy-dev-approval-task","params":[{"name":"pipeline","value":"$(context.pipelineRun.name)"},{"name":"description","value":"Approval from pipeline $(context.pipeline.name)"},{"name":"approvers","value":["john"]}],"taskRef":{"apiVersion":"tekton.automatiko.io/v1alpha1","kind":"ApprovalTask","name":"approvaltask"}},{"name":"deploy-dev-approved-task","params":[{"name":"decision","value":"APPROVED"},{"name":"comment","value":"$(tasks.deploy-dev-approval-task.results.comment)"}],"runAfter":["deploy-dev-approval-task"],"taskRef":{"name":"print-decision"},"when":[{"input":"$(tasks.deploy-dev-approval-task.results.decision)","operator":"in","values":["true"]}]},{"name":"deploy-dev-rejected-task","params":[{"name":"decision","value":"REJECTED"},{"name":"comment","value":"$(tasks.deploy-dev-approval-task.results.comment)"}],"runAfter":["deploy-dev-approval-task"],"taskRef":{"name":"print-decision"},"when":[{"input":"$(tasks.deploy-dev-approval-task.results.decision)","operator":"in","values":["false"]}]}]}} creationTimestamp: "2022-08-19T13:06:37Z" finalizers: - runs.tekton.dev/finalizer generation: 1 labels: tekton.dev/memberOf: tasks tekton.dev/pipeline: testpipeline2 tekton.dev/pipelineRun:...

> I wonder if labels from the custom task should be propagated to the Run, similar to how labels from a Task / Pipeline are propagated today. This would certainly...

could we rely on the control that the custom resource always uses label with the name of the run? ```` labels: tekton.dev/runName: testpipeline2-run-1660914397704-deploy-dev-approval-task ```` that way knowing the run name...

any chance this could be revisited and considered to be merged? If there is only one provider that has the issue with it maybe this could be gated with opt...