Martin Svanberg
Martin Svanberg
I would be in favor of renaming `single` to something like `get_single_unchecked`, or some other similarly clunky name, to discourage its use. Or it could be removed entirely. I've seen...
Could it be an option to run the window systems in e.g. `PreUpdate` instead to avoid the panic? Or to use `get_single` instead of `single` as a defensive measure?
What do you mean by "rate limiter" here? Is it the MTU limit? It seems like the primary problem is that you can't predict the size of encoded messages in...
@cBournhonesque Thanks for the context! I'm trying to become more familiar with the code and hope to contribute in the future :)
Hey, nice work! I was just about to have a look at this, but then it turns out you already did the work. I tried this PR in my game...
One little nit about this approach is that `cargo test --workspace` seems to not like the relative paths in `rustflags`, probably because the test program gets invoked from a directory...
Fwiw I am still using this branch and it works well for me. Workspace support would be nice to have but is not a dealbreaker, especially since you can just...
https://github.com/cBournhonesque/lightyear/pull/452
I don't fully understand this review comment, did you leave something out?
Hey, sorry for the slow turnaround on this. I pushed a fix just now