react-native-data-table icon indicating copy to clipboard operation
react-native-data-table copied to clipboard

"A trailing comma is not permitted after the rest element" Babel error

Open sworupSussol opened this issue 6 years ago • 4 comments

The newer version of Babel does not support trailing comma after code like

const {
    style,
    textStyle,
    width,
    onPress,
    text,
    isSelected,
    isAscending,
    ...containerProps,
  } = props;

Two files have this problem. DataTable.js and HeaderCell.js

sworupSussol avatar Oct 29 '18 10:10 sworupSussol

Given you've made 2 PRs Fixed in #28 + #29 .

Chris-Petty avatar Oct 29 '18 21:10 Chris-Petty

Yes, I made the first PR in a hurry, did not realized there were more changes, so I closed it.

sworupSussol avatar Oct 30 '18 05:10 sworupSussol

Ah whoops, I thought they were merged not closed. This issue is still a good tweak.

Chris-Petty avatar Oct 31 '18 01:10 Chris-Petty

Reopened the PRs

sworupSussol avatar Oct 31 '18 04:10 sworupSussol