react-native-data-table icon indicating copy to clipboard operation
react-native-data-table copied to clipboard

Published 20 hours ago • verified publisher icon msupply-foundation

Remove peer dependencies

Open JulianKingman opened this issue 7 years ago • 3 comments

Is there a reason for this to depend on Realm for it's ListView component? It would be great if that was removed, can it just use the native ListView component?

I think there's a general push to remove peer dependencies in code, as it makes packages difficult to work with.

JulianKingman avatar Mar 09 '17 17:03 JulianKingman

I'd be happy to make a PR. To expand, eliminating realm is particularly important because it requires somewhat complicated linking, which is not possible in the exponent development environment.

JulianKingman avatar Mar 09 '17 17:03 JulianKingman

@JulianKingman Sorry for the delay, all busy with other projects. Please do make a PR, would be great for others to be able to use this component without needing realm. Will need to support dependency injection somehow for those who do want to use Realm.ListView (including us).

edmofro avatar Apr 10 '17 06:04 edmofro

Thanks, here's my PR: https://github.com/sussol/react-native-data-table/pull/5

JulianKingman avatar Apr 10 '17 19:04 JulianKingman