Michael J. Sullivan

Results 117 comments of Michael J. Sullivan

There's some design work needed to figure out exactly what error message should be output. An access policy is violated if one or two things happens: 1. Every allow rule...

From an implementation perspective, we'll need to keep the policy expressions separate in the IR for DML, and track the error messages we want. Currently we combine them all together...

Not a bad idea. I think a more idiomatic version (and what we should put in the docs) would be: `update Person filter .id = 'abc' set { middle_name :=...

Doing migrations on big schemas is super slow largely because of all the time spent serializing the schema for communication with worker processes. The compiler worker always sends back the...

I can't reproduce the hanging, but I do get an error when doing the migration. A simplified case is: ``` abstract annotation ann1; type T { annotation ann1 := 'test!';...

I'm both very confused and curious about the hanging issue: you have filed multiple bugs where you reported hanging in cases where errors were generated, and I'm pretty unsure what...

Oh, and actually, I can't reproduce any issue when doing the migration flow in the normal way. I was able to provoke an error by using `populate migration`, but that...

@vpetrovykh let me know if you want to take a look at this one, otherwise I'll try to get to it

That should be implementable. The main semantic question is what would happen if it conflicts on *multiple* fields. Options are 1. Execute the first one 2. Execute them all? This...

Yeah, I think this should be possible. I actually implemented this in https://github.com/edgedb/edgedb/pull/2196 and then backed it out in https://github.com/edgedb/edgedb/pull/2202. The thing that is potentially weird about it is that...