Michael J. Sullivan
Michael J. Sullivan
We're doing a `splat_strategy` thing instead
Do those uuids match any `id`s of `schema::Object`s in your database?
We have merged a working persistent cache, but need some additional work to get functions working.
Current issues: - [x] Test failures when using https://github.com/edgedb/edgedb/pull/7497 - [x] Increased log spew because of `DROP FUNCTION IF EXISTS` - [ ] I once observed "function does not exist"...
https://github.com/geldata/gel-python/blob/bb93ed75d420a4b7029c819fc8b9e5b467cb267f/gel/protocol/protocol.pyx#L1181-L1184 `CodecsRegistry` uses `LRUMapping`s. If `type_id` gets evicted from the LRU between `has_codec` and `get_codec`, then we will raise a `LookupError`.
https://github.com/geldata/gel-python/blob/bb93ed75d420a4b7029c819fc8b9e5b467cb267f/gel/protocol/lru.pyx#L51 The thread-safety of `OrderedDict` is not 100% clear to me. It's certainly not documented as thread-safe, and the reference python implementation is not. The C implementation *probably is*, though...
> [gel-python/gel/protocol/protocol.pyx](https://github.com/geldata/gel-python/blob/bb93ed75d420a4b7029c819fc8b9e5b467cb267f/gel/protocol/protocol.pyx#L1181-L1184) > > Lines 1181 to 1184 in [bb93ed7](/geldata/gel-python/commit/bb93ed75d420a4b7029c819fc8b9e5b467cb267f) > if reg.has_codec(type_id): > out_dc = reg.get_codec(type_id) > else: > out_dc = reg.build_codec(type_data, self.protocol_version) > > `CodecsRegistry` uses `LRUMapping`s. If...
Fun! Requires `\set display-typenames on`. ``` select Basic { parent := {} }; ``` I think works.
Looking good so far
I wanted to mark this as "request changes" but you can't do that to your own PR apparently!