Michael J. Sullivan

Results 175 comments of Michael J. Sullivan

The query builder probably ought to automatically quote reserved names by itself, though

Yes and no. The SQL we would generate gets elided during pgsql, but it still has nontrivial impacts on the IR side (since we might have to recompile a shape...

We definitely shouldn't be including things like `TakeWhileMN` in error messages

We need to figure out how to make check warnings not appear once for each platform

(Get rid of all the unused imports)

The big remaining thing needed is tests. There probably *ought* to have been some tests before, but now the parsing is much more involved so we definitely need them.

Oh, clean up the unused imports please

Do the tuples and array support trailing commas? They should, and we should make sure to test it

Hm, actually now that I think about it more, maybe we should require the named tuples to be in order, also? That matches edgeql better (where the order is important),...

Oh, and *leading* spaces after an opening `(` or `[`