Patch invert if

Open nbauma109 opened this issue 3 years ago • 1 comments

This PR inverts if conditions and statements when line numbers are in the wrong order. The next statements have sometimes inferior line numbers than then statements, making it impossible to debug.

I didn't notice any issue with if/else statements. I noticed the issue only with if statements that return or throw.

As I negate the condition I try to avoid double negation.

Unit tests included.

NOTE; I have a slightly better version of LineNumberVisitor in the other PR with MinMaxLineNumberVisitor. I deprecated LineNumberVisitor rather than duplicating MinMaxLineNumberVisitor here to avoid a merge conflict of duplicated classes. We can clean this up if we decide to merge this all together.

Apr 02 '22 08:04 nbauma109

Hi @mstrobel Please help moving forward with this PR Thanks !

Apr 02 '23 09:04 nbauma109