Matt Stone

Use tox so we can test multiple python versions locally

3

GHA does this, but it'd be more convenient if tests and checks could be run without pushing and the overhead of GHA

Add `require`

1

`assert` should be avoided outside unit tests. The Google style guide [requires this](https://google.github.io/styleguide/pyguide.html#244-decision): > Do not use `assert` statements in place of conditionals or validating preconditions. They must not be...

https://github.com/fulcrumgenomics/fgpyo/pull/69/files#r1629636228

We should enable the set of rules recommended by the template https://github.com/fulcrumgenomics/python-template/blob/89bc226c7c3de405daa9398b4baa2af137230332/pyproject.toml#L84-L87

Add function(s) to set the 5' most alignment on a read as primary

1

This has come up in multiple client contexts and would be very helpful to have. I think there are two functions that would be helpful: ```python def set_primary_alignments(template: Template) ->...

feat: DataSubclassMixin

1

Per Slack discussion, it'd be helpful to have a generally reusable alternate constructor for subclassed dataclasses. I chose to implement as a mixin. I think we probably want to always...

Compose a `scalafmt` configuration that applies Nils and Tim's preferred conventions

1

`fgbio` PRs are expected to adhere to "tim-format," which encompasses Nils and Tim's preferred conventions for formatting Scala code. e.g. https://github.com/fulcrumgenomics/fgbio/pull/958#discussion_r1466961356 The conventions encompassed by "tim-format" should be documented somewhere...