xctrim icon indicating copy to clipboard operation
xctrim copied to clipboard

Mismatch between trimmed architectures and supportedArchitectures in plist

Open lumiasaki opened this issue 1 year ago • 0 comments

Issue:

When using xctrim, if the xcframework contains an architecture of ios arm64 and the --platform parameter passed is "ios arm64 armv7", the trimmed result only retains the ios_arm64 folder. However, the supportedArchitectures in the plist incorrectly lists it as "ios_arm64_armv7".

Impact:

This inconsistency causes Xcode to search for the ios_arm64_armv7 framework based on the plist, leading to an error since the framework for ios_arm64_armv7 doesn't exist post-trimming.

Steps to Reproduce:

  • Have an xcframework only with ios arm64 architecture.
  • Use xctrim with the --platform parameter set to "ios arm64 armv7".
  • Observe that the trimmed result only has the ios_arm64 folder.
  • Check the plist to see supportedArchitectures listed as "ios_arm64_armv7".

Expected Behavior:

The supportedArchitectures in the plist should match the actual trimmed architectures in the xcframework.

Actual Behavior:

The plist lists more architectures (ios_arm64_armv7) than what's actually present in the trimmed xcframework. 截屏2023-08-21 0 34 38 截屏2023-08-21 0 35 59

I have fixed it and created a Pull Request for it, I would be grateful if it could get your considering.

lumiasaki avatar Aug 20 '23 15:08 lumiasaki