Michael Stenta

Results 195 comments of Michael Stenta

Meant to respond to this @paul121: > I think we need to implement a hook to update existing schema on sites if we change this here. I'm not sure anything...

I like that reasoning @symbioquine - and leaving this as-is means that "Owner" will not appear on assets unless it is filled in. (There is still an "Owner" column" in...

Ah hmm tests are failing: ``` Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for system.action.asset_assign_action with the following errors: system.action.asset_assign_action:configuration missing schema ```

> Ah hmm tests are failing: I pushed a commit that attempts to fix this... waiting for results from GitHub Actions... https://github.com/mstenta/farmOS/actions/runs/2934888499

Getting a different schema error now, related to the changes to Views config: `Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.farm_people with the following errors: views.view.farm_people:display.default.display_options.nothing missing schema` Will need to debug that...

I figured out the other schema error. @jgOhYeah it appears you may have copied and pasted a chunk of code into the `views.view.farm_people.yml` file, does that sound correct? There were...

No worries! Easy fix. :-) I think this is ready for final review and merge now. All tests are passing.

(Just merged my fixup into the initial commit and rebased onto latest `2.x` to resolve `CHANGELOG.md` conflict.)

Rebased and added one more commit to document the new owner field in the user guide and data model docs. If tests pass I'll merge this.

Merged! At long last!!! Thanks again @jgOhYeah! :-D :tada: