framehop icon indicating copy to clipboard operation
framehop copied to clipboard

test failure on i386.

Open plugwash opened this issue 11 months ago • 1 comments

We recently updated fromhop in Debian and it's tests failed on the test runners for i386

103s ---- rule_cache::tests::test_cache_entry_size stdout ----
103s thread 'rule_cache::tests::test_cache_entry_size' panicked at src/rule_cache.rs:141:9:
103s assertion `left == right` failed
103s   left: 20
103s  right: 24
103s stack backtrace:

Reading the code, I came to the conclusion that it was normal for this structure to be smaller on i386, due to the lower alignment requirements.

As such I applied the patch at https://salsa.debian.org/rust-team/debcargo-conf/-/blob/16eff923c3e9eddc6b9a3afd006697caf8c303c1/src/framehop/debian/patches/fix-test-i386.patch

plugwash avatar Dec 27 '24 13:12 plugwash

Thanks for the note! Yes, I never anticipated that the tests would be run on 32 bit platforms, so it's fun to see that Debian does this.

Also, thanks for showing me the fix - I always assumed that core::mem::align_of::<u64>() was 8 everywhere. TIL!

I'd be happy to merge a PR with your fix.

mstange avatar Dec 29 '24 15:12 mstange