passforios icon indicating copy to clipboard operation
passforios copied to clipboard

add submodule support

Open ghost opened this issue 7 years ago • 8 comments

I have my personal passwords and then want to store my project password in a separate folder for access control issues.

Can your software just do the next step to do:

git submodule init git submodule update

?

Thanks Jon

ghost avatar May 10 '17 21:05 ghost

Hi Jon, thanks for the suggestion. I understand your idea, but we should support multiple keys in the first place. Since submodule may have different keys, we should provide matching keys for encryption/decryption.

mssun avatar May 11 '17 03:05 mssun

yeah you mean first?

On May 10, 2017, at 20:07, Bob Sun [email protected] wrote:

Hi Jon, thanks for the suggestion. I understand your idea, but we should support multiple keys in the first place. Since submodule may have different keys, we should provide matching keys for encryption/decryption.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost avatar May 11 '17 05:05 ghost

Yes, we will figure how to support multiple pairs of keys first.

mssun avatar May 11 '17 05:05 mssun

ok makes sense, but for default, if no key in the submodule root dir then should default to the gpg key in the directory above, correct?

On May 10, 2017, at 22:21, Bob Sun [email protected] wrote:

Yes, we will figure how to support multiple pairs of keys first.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost avatar May 11 '17 05:05 ghost

I guess we should find .gpg-id in the following order: current dir, parent dir ,..., root. And use the first .gpg-id found. Correct?

We will play around git submodule in Pass (command line) first, and then implement it in Pass for iOS.

yishilin14 avatar May 11 '17 05:05 yishilin14

sounds like a plan

On May 10, 2017, at 22:41, Yishi Lin [email protected] wrote:

I guess we should find .gpg-id in the following order: current dir, parent dir ,..., root. And use the first .gpg-id found. Correct?

We will play around git submodule in Pass (command line) first, and then implement it in Pass for iOS.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost avatar May 11 '17 06:05 ghost

It seems like we could solve issue #52 together with this one.

  • Both features require importing multiple keys (especially multiple public keys).
  • Both features require encrypting files using public keys indicated in the "nearest" .gpg-id config.

Just my two cents.

yishilin14 avatar May 11 '17 09:05 yishilin14

What is the state of this feature? As far as I can tell, .gpg-id is already supported now. But I think it isn't a requirement as there are also use cases where a submodule may make sense for a single user. And even when multiple users are involved, read-only access works in any case.

I think the feature should work like this:

  • By default, the app should run git submodule update --init --recursive on every pull.
  • There could be a switch in the options that enables the --remote flag (so the full command would be git submodule update --init --recursive --remote). This ensures that the Git submodule is updated to its latest commit, not the one that's referenced in the main repository.

lukasbestle avatar Jul 24 '21 13:07 lukasbestle