passforios icon indicating copy to clipboard operation
passforios copied to clipboard

Password suggestions work, but actually they don't

Open doebi opened this issue 2 years ago • 4 comments

First of all, I really love this extension. It is for me finally a take on password security that gives me the security of proper self-managed encryption and still flexibility to fit into everyday use. Keep it up!

I really like the seamless integration with iOS password providers, that enables me to launch this app from whereever a password is needed. When I go to paypal.com for example I get presented with this hint to login using my account right away:

pass-1

Awesome, I just have to click that blue button and get to unlock my password. But here is the catch, as soon as I click said button, my screen looks like this:

pass-2

Huh? I actually expected to just type in my encryption key and not having to manually pick the correct password. Please not how the correct password, even the full path to the .gpg file is at the top, while there are completely unrelated passwords in the list for suggestions.

pass-3

After typing something into the search bar to narrow it down I can finally see the correct entry in the list and select it.

pass-4

I expected to see this prompt right after clicking the blue button form within safari.

For reference: the web extension is able to indentify and present just the correct entry:

pass-5

What is going on here, where is the issue and how can we solve it? Thanks for your efforts, the work on this extension is much appreciated.

doebi avatar Nov 24 '21 23:11 doebi

Hi, we implemented a very fuzzy search algorithm. From your description, I assume you are using url/username to store the password entries. In this case, we will suggest all password entry names with the same username (i.e., the email address).

I know a lot people are using this kind of file structure. We can definitely have a better suggestion algorithm.

mssun avatar Dec 29 '21 22:12 mssun

Hi, thanks for your reply.

I think the fuzzy search is really handy when it comes to searching. However, in the scenario I am describing the app knows exactly what is needed, so there is absolutely no need for searching. As pointed out in the description, the full path to the gpg file is known, yet I am presented with a search bar. I don't get why nobody else is seeing this as a major issue.

I am not too familiar with your codebase so it would take some time to get going, are you willing to look into this? Essentially replacing the fuzzy search with a string matching to skip 2 views and saving valuable minutes of lifetime for any login procedure.

Thanks!

doebi avatar Dec 30 '21 13:12 doebi

@mssun Any chance to get you looking into this?

doebi avatar Jan 06 '22 15:01 doebi

With the recent update to 0.12.0 I saw an improvement to this issue. Thanks for taking on it!

One additional note however: The app correctly provides me with the password prompt, but the keyboard is not shown. I guess this can be easily fixed with setting the focus on the password prompt automatically.

Thank you very much!

doebi avatar Jan 18 '22 14:01 doebi