passforios icon indicating copy to clipboard operation
passforios copied to clipboard

ssh passphrase is asked even if no passphrase is set

Open 532910 opened this issue 4 years ago • 10 comments

It asks for ssh passphrase when no passphrase is set. Moreover it offers to save it.

532910 avatar Jun 29 '20 13:06 532910

same here with the app store version.

adadnc avatar Jun 29 '20 15:06 adadnc

In the moment the keys are imported there is currently no logic or validation available to verify that:

  • A key is valid.
  • A public/private key is actually a public/private key.
  • A private key is encrypted by a passphrase.

It just saves the keys and the passphrases independently and brings them together only later when they are required.

This could truly be improved to provide immediate feedback to the user.

SimplyDanny avatar Jun 29 '20 20:06 SimplyDanny

It simply doesn’t accept keys without password.

adadnc avatar Jul 06 '20 20:07 adadnc

It's false, it accepts ssh keys without password.

532910 avatar Jul 06 '20 21:07 532910

I'm using a key generated by ssh-keygen with 2048 bits size that doesn't have a passphrase:

$ openssl rsa -text -noout -in .ssh/id_rsa
Private-Key: (2048 bit)

The private key was generated a couple of years ago (before 2010...) in old PEM format...:

$ cat .ssh/id_rsa
-----BEGIN RSA PRIVATE KEY-----
...strange-magical-characters...
-----END RSA PRIVATE KEY-----

I have just installed the app (Pass for iOS 0.9.0 (21)) on my iPadPro 11" 2nd gen with iOS 14 from the App Store.

I have transferred the files ssh_key (containing the SSH private key in the format shown above), gpg_key and gpg_key.pub (containing both the private and public GPG keys) from my MacBook Pro running MacOS X 10.15.6 using the Finder's sharing function. The app has successfully imported the keys.

I was asked to enter the password of my private GPG key. I did, made sense, it worked.

Then I tried to setup the GIT repo:

Git repository URL: ssh://[email protected]/user/private-repo.git Username: git

When I try to clone, a dialog opens up (in German) called "Password" asking me to enter the password (?) of my SSH key.

tarak avatar Sep 20 '20 11:09 tarak

Screenshot of the SSH key setup:

Screenshot of the "Password" dialog that appears after "Clone" is clicked:

Screenshot of the error message (appears no matter what is given in in the dialog above, even if just "ok" without input is clicked):

tarak avatar Sep 20 '20 12:09 tarak

I'm seeing the same issue as @tarak. I suspect something has changed in iOS 14 that broke the way the SSH key is handled internally, but that's just a wild guess. At any rate, this renders the app unusable for me since I can't clone my repo.

Edit: To clarify, I'm currently using iOS 14.2 on an iPhone 7

Edit 2: Embarrassingly, the issue in my case was that I had the wrong SSH public key on my gut server. If anyone runs into @tarak’s issue, make sure you have the public key corresponding to your Pass private key properly installed on the server.

djmoch avatar Nov 30 '20 20:11 djmoch

hi guys! Unfortunately, this one is still relevant:( Pass for iOS 0.12.0 (62) from AppStore, iPadOS 15.6.1

dmchmk avatar Dec 18 '22 19:12 dmchmk

Hi, on iPadOS 17.1.2, Pass for iOS 0.14.0 still an issue. Can't use a ssh key without passphrase. Got it working generating a new key with passphrase only for this app, but it's a workaround (well, it could be a good practice, to be honest).

benegetto avatar Jan 10 '24 10:01 benegetto