passforios icon indicating copy to clipboard operation
passforios copied to clipboard

RFE: auto-fill: support extracting username from the file name (`domain.tld/username`)

Open intelfx opened this issue 5 years ago • 12 comments

Consider a pass hierarchy where site domain name is encoded in the last directory name, and site login is encoded in the file name itself. Example follows:

Password Store
└── web
    ├── <...>
    │   └── <...>
    ├── github.com
    │   └── intelfx
    └── <...>
        └── <...>

This layout is not my invention — it is suggested by the dannyvankooten/browserpass extension. Also, this layout naturally occurs when you need to store more than one credential pair for a specific site.

As of now, passforios will only try to extract login name from a login: field in the password file itself. However, storing login name in the password file is unwieldy, because there is no direct support for this in pass insert.

This feature request is to support an alternative way of doing things: web/github.com/intelfx, if matched against www.github.com (as per #138) and there is no login: field inside, shall yield a username of intelfx.

More specifically:

  1. if the domain name was not matched against the file name, and
  2. if there is no login: field inside the password file,
  3. then the user name shall be equal to the password file name.

web/github.com/intelfx -> match = github.com, login = intelfx, password = file contents.

intelfx avatar Jan 10 '19 09:01 intelfx

Actually, browserpass prefers login: in your pass file. See https://github.com/browserpass/browserpass#requirements

xslim avatar Mar 04 '19 09:03 xslim

@xslim

Not as far as I can see:

Your password filename must match your username or your file must have a line starting with login:, user: or username:, followed by your username.

(emphasis mine)

intelfx avatar Mar 04 '19 10:03 intelfx

A related PR: https://github.com/mssun/passforios/pull/265

yishilin14 avatar May 17 '19 04:05 yishilin14

Merged. Will be released next week.

yishilin14 avatar May 17 '19 15:05 yishilin14

@yishilin14 So far, this hasn't appeared to work either in the production build or in TestFlight build. Please reopen?

intelfx avatar Sep 19 '19 12:09 intelfx

@intelfx, thanks for the report. Can you indicate the version you are using?

mssun avatar Sep 19 '19 18:09 mssun

@mssun Actual AppStore build (0.7.0) and actual TestFlight build (0.8.0 (3)).

intelfx avatar Sep 19 '19 18:09 intelfx

For the record, the site used to reproduce was github.com, using Chrome's incognito mode.

intelfx avatar Sep 19 '19 18:09 intelfx

Is it actually possible to finally make a release that will contain this fix?

This was fixed for some time in TestFlight builds, but my TestFlight access got somehow revoked one day, so yeah, can something be finally done about this?

intelfx avatar Sep 27 '20 11:09 intelfx

@intelfx This fix should have been released a year a ago. Let me take a look why it doesn’t work anymore.

Feel free to send us an email if you’d like to try Pass on TestFlight again.

yishilin14 avatar Sep 27 '20 15:09 yishilin14

I just did a test. This function does not work in the AppStore build (0.9.0), and I have no clue about when this feature became unavailable. But it works in the latest TestFlight build.

@mssun When can we release the next AppStore version?

yishilin14 avatar Sep 28 '20 18:09 yishilin14

Any luck?

Thanks.

intelfx avatar Oct 15 '20 12:10 intelfx