msrd0

Results 197 comments of msrd0

I just looked through the history of gotham and it looks like `StateData` was introduced together with `State`, so it's not a leftover from a previous refactor. Does anyone know...

Considering #494, removing `StateData` might not be something we'd want to do. If a middleware sometimes puts type `Foo` into your state and sometimes doesn't, we could map `Option` to...

> How so? You could still make the opinionated assumption that Option is mapped to try_take. Well, `impl FromState for T` using `take` and `impl FromState for Option` using `try_take`...

It is not possible to attach any data except for the status code to a `HandlerError`. I don't believe that a `HandlerError` should be upgraded to full response creation abilities...

Why do you need to serve the same content under two different urls (with and without a trailing slash) in the first place? These urls are certainly different and I...

The [`tokio-openssl`](https://crates.io/crates/tokio-openssl) crate has been updated to support std futures and tokio 1.0 so this is no longer blocked.

I once had a PR merged, but I haven't read a single comment from the developers, neither on PRs nor on issues

I think there is a 3rd option: Make the proc-macro return something like ```rust syn::Error::new(self.meta.span(), format!( "Expected valid identifier, found `{name}`. Diesel automatically renames invalid identifiers, perhaps you meant to...

I see the same behaviour on ArchLinux, same version. ``` $ augtool -At "Toml.lns incl $(pwd)/Cargo.toml" -I lenses/ print /files /files ```

I'm not sure which `Cargo.toml` file I initially encountered this problem with, but [this one](https://github.com/msrd0/gotham_formdata/blob/master/Cargo.toml) and [this one](https://gitlab.com/msrd0/gotham-restful/-/blob/master/Cargo.toml) are two that fail to parse with augeas.