Jonathan Protzenko

@beurdouche: can you try adding dist/gcc-compatible to the include path? @polubelova: basically the problem is that this test file runs both the scalar, 128 and 256 tests in a single...

@Kachoc and I have discussed this repeatedly and have come to the conclusion that there should be one test file per vectorization level (just like there is one C file...

There are several tables in the article, which one are you referring to? If you are adamant that 200 is a well-chosen constant and suitable for all use-cases, then the...

hi @Frosne, what is the status of this PR? Santiago had a question: > Can you compare performance before/after this PR? Do you have some stats? Thanks!

@Frosne I am also noticing that this line is incorrect: https://github.com/project-everest/hacl-star/pull/532/files#diff-2362ae7382c03775602df49a51177c268f05d03b7825dcf292b3fa18f92e3e53R13 you need `$(shell uname)`, not `$(uname)`. Thanks.

To summarize... the following needs to be fixed for this PR to move forward: - Santiago's comment needs to be addressed - https://github.com/project-everest/hacl-star/pull/532#issuecomment-1169187922 needs to be addressed - the *second*...

I took another look at this: to fix the build on OSX, it might be the case that in addition to point 2, you need this change (untested) as well:...

This wasn't caught because dist/mozilla does not run configure, so does not get the benefits of this: ``` 523 if [[ ! $target_arch == "aarch64" ]]; then 524 echo "LDFLAGS...

Adding the header is a good idea, but will still leave unresolved symbols. Can we add the .c file just to give a successful build, and then you replace it...

Great! Thanks so much. It'll unblock the build for all OSX users.