Jonathan Protzenko

Results 404 comments of Jonathan Protzenko

Curious to hear about Mirage's special needs. We're hoping that the OCaml bindings we're submitting are the one package to rule them all ™️. If you need to cherry-pick a...

the hacl-star package uses dune, but the hacl-star-raw package does not... it uses a Makefile... the reason is as follows: - the directory contains our C generated code, and we...

The Makefile should honor CC and CFLAGS, yes. If you're able to give it a go and submit a PR for the hacl-star repository, that would be super helpful --...

@R1kM tried but it didn't work, @msprotz to take a look

This might be improved by the recent fix to unused variable elimination. @R1kM can you tell me whether this is still valid?

hi everyone, just a friendly ping on this PR; is there any way I can help the discussion make progress? happy to provide more context, explanations, or perf measurements if...

> this comment still applies. I'm happy to do that, although I touched up a couple things manually, so it might take a few PRs in HACL to get the...

After a few weeks of upstream work, here is a revised PR. Highlights: - thanks to upstream proofs showing that various internal steps (update, update_blocks, update_last) are identical for SHA2-224...

Thanks both @gpshead and @erlend-aasland! @erlend-aasland what warning are you seeing? Is it a cast from python's size_t to uint32_t? I wasn't able to reproduce (neither on gcc-11/x86_64/Linux, nor {clang,gcc-12}/x86_64/OSX),...

I fixed the final review comments... @erlend-aasland do I need to re-request a review from you, or is there anything I can do? thanks!