aks-fabrikam-dronedelivery icon indicating copy to clipboard operation
aks-fabrikam-dronedelivery copied to clipboard

Missing parameters in 05-aks-cluster.md step 3 and 6

Open fidelcasto opened this issue 3 years ago • 0 comments

Hi, In the documentation there seems to be something missing in step 3 and 6 of the file 05-aks-cluster.md file.

At step 6, the following parameters are also required by the ARM Template : ingestionPrincipalId and packagePrincipalId

I would add these lines to step 3 :

$PACKAGE_ID_NAME=$(az deployment group show -g $(application-ressourceGroupName) -n workload-stamp-prereqs-dep --query properties.outputs.packageIdName.value -o tsv)

$PACKAGE_ID_PRINCIPAL_ID=$(az identity show -g $(application-ressourceGroupName) -n $PACKAGE_ID_NAME --query principalId -o tsv)

And update step 6 like the following :

az deployment group create -f ./workload/workload-stamp.json -g rg-shipping-dronedelivery -p droneSchedulerPrincipalId=$DRONESCHEDULER_ID_PRINCIPAL_ID -p workflowPrincipalId=$WORKFLOW_ID_PRINCIPAL_ID -p deliveryPrincipalId=$DELIVERY_ID_PRINCIPAL_ID -p acrResourceGroupName=$ACR_RESOURCE_GROUP -p ingestionPrincipalId $INGRESS_CONTROLLER_ID_PRINCIPAL_ID -p packagePrincipalId=$PACKAGE_ID_PRINCIPAL_ID

I just had this tested on my end and it seems to work like charm with these corrections.

Regards

fidelcasto avatar Sep 20 '21 12:09 fidelcasto