mspae
Wavesurfer 2 support
I know the readme says it's in the making... is there an ETA?
Also, I can't find the docs for wavesurfer 1, so I'm kind of stuck.
Is it a lot of work to migrate to v2? Is some of the work done already, and if so is the code available anywhere?
Thanks.
I've been working on getting wavesurfer.js itself release-ready so I haven't been able to put in much work for react-wavesurfer. I've done some stuff today though and I think I've gotten pretty far. (Check out the v2 branch) – Currently timeline and minimap plugins don't work yet, I think the rest does more or less.
A lot of the functionality which react-wavesurfer had to previously to work properly with wavesurfer.js in a component format is no longer required because v2 is architected to be much more modular. For instance wavesurfer.js isn't a peer dependency anymore but can be bundled together with react-wavesurfer. Also the responsive feature is now part of wavesurfer.js core. The dynamic plugin API will make it much easier to work with wavesurfer in this way (the plugin components are already greatly reduced in size)
Please bear in mind that it is not yet finished (see the issue with minimap and timeline plugin) – I have the feeling this might also be an issue with wavesurfer.js core dynamic plugin API.
I'd really welcome any help I can get (testing, hacking, fixing … whatever) – the more people are involved the quicker we'll have a stable library! :)
@nafg What do you mean with docs for v1? (This? https://wavesurfer-js.org/docs/)
I don't know, are those docs for version 1 or version 2?
On Sun, Oct 22, 2017 at 12:08 PM Martin Spencer [email protected] wrote:
@nafg https://github.com/nafg What do you mean with docs for v1? (This? https://wavesurfer-js.org/docs/)
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mspae/react-wavesurfer/issues/70#issuecomment-338488904, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGAUGYV8LsG6nGURknoTM8j0O-90Scnks5su2iSgaJpZM4P9BpM .
@nafg At this point all documentation that is not explicitly for version 2 is for version 1.
Version 1 docs: http://wavesurfer-js.org/docs Version 2 docs: https://wavesurfer-js.org/doc/
Ok thanks for clarifying
On Mon, Oct 23, 2017, 4:03 PM Martin Spencer [email protected] wrote:
@nafg https://github.com/nafg At this point all documentation that is not explicitly for version 2 is for version 1.
Version 1 docs: http://wavesurfer-js.org/docs Version 2 docs: https://wavesurfer-js.org/doc/
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mspae/react-wavesurfer/issues/70#issuecomment-338779752, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGAUIwc4O2-R63Z4Vv5hn1Qq31SOtZPks5svPEbgaJpZM4P9BpM .