quillnote icon indicating copy to clipboard operation
quillnote copied to clipboard

Published 20 hours ago • verified publisher icon msoultanidis

ETag header should be enclosed in quotes.

Open jsixface opened this issue 3 years ago • 3 comments

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag

The Nextcloud implementation expects the ETag to have quotes and the quillnote does not send the quotes. Because of this, the server is not able to find the note we're trying to update and rejects the update. Details at https://github.com/nextcloud/notes/pull/883

This should fix #179

jsixface avatar Aug 26 '22 20:08 jsixface

Nice. For anyone else, a binary is here as it seems this isn't being merged and I'm not sure why.

I had to revert a change you made on toMediaType to get it to compile. Unsure why, thoughts?

magnus-ISU avatar Oct 05 '22 05:10 magnus-ISU

I too, am curious.

daffydock avatar Oct 09 '22 11:10 daffydock

toMediaType change is not related to the fix. I guess it was a suggestion from the Android Studio. If that's breaking something, I can revert that one.

jsixface avatar Oct 10 '22 14:10 jsixface

Reverted back the toMediaType() change. Can we get this merged ?

jsixface avatar Oct 28 '22 15:10 jsixface

Reverted back the toMediaType() change. Can we get this merged ?

Hello i created a fork until @msoultanidis is back, and i have merged this patch too.

NeNpO avatar Oct 28 '22 19:10 NeNpO

@NeNpO please make a github release

magnus-ISU avatar Oct 28 '22 20:10 magnus-ISU

@NeNpO please make a github release

This is what i am doing right now :)

NeNpO avatar Oct 28 '22 20:10 NeNpO

Why was this closed? As far as I can tell, the app hasn't been updated.

EDIT: ah, quillpad is the successor project

magnus-ISU avatar Nov 18 '22 19:11 magnus-ISU