dproto icon indicating copy to clipboard operation
dproto copied to clipboard

Support proto3

Open Downchuck opened this issue 9 years ago • 7 comments

https://github.com/google/protobuf/blob/master/CHANGES.txt

"In proto3, the language is simplified, both for ease of use and to make it available in a wider range of programming languages. At the same time a few features are added to better support common idioms found in APIs."

Downchuck avatar Mar 11 '15 19:03 Downchuck

I would _love_ to do this, but at the moment I've got way too much to deal with...plus even the 2.x line isn't up to date. I did take a look at some of the changes, and I think they're great.

msoucy avatar Mar 11 '15 20:03 msoucy

I completely understand -- it's my intention to submit a couple of pull requests. The code base for dproto is wonderfully accessible.

Downchuck avatar Mar 11 '15 21:03 Downchuck

Why thank you! I have to thank Square for their initial protoparser that I based this parser off of, but I'm glad that it's accessible. That was one of my goals for the project.

msoucy avatar Mar 11 '15 21:03 msoucy

There is some effort to get D support for version 3 into the official protocol buffers repo. You should get in contact with Dragos Carp https://github.com/dcarp/protobuf.

MartinNowak avatar May 06 '16 14:05 MartinNowak

Has there been any progress on this?

WebDrake avatar Aug 12 '16 13:08 WebDrake

Timestamp doesn't seem supported

ref: https://developers.google.com/protocol-buffers/docs/proto3 => unexpected label: Timestamp

timotheecour avatar Apr 07 '17 04:04 timotheecour

@msoucy optional modifier shouldn't exist in proto3 (ie should be implicit), but dproto is being inconsistent:

syntax = "proto3";

message A{
  //Foo foo=1; // gives an error but should be accepted
  optional Foo foo=1;  // works but shouldn't
  string foo2=2;  // accepted, as it should
}

message Foo{
  int32 bar=1;
}

timotheecour avatar Apr 09 '17 23:04 timotheecour