lk2nd icon indicating copy to clipboard operation
lk2nd copied to clipboard

Published 20 hours ago • verified publisher icon msm8916-mainline

Add SONY Rhine and pm8941 SPMI regulators

Open konradybcio opened this issue 3 years ago • 5 comments

konradybcio avatar May 14 '21 11:05 konradybcio

Sadly no display, nobody cared enough to enable it in the original BL, but hey, at least the eMMC isn't suicidal..

konradybcio avatar May 14 '21 12:05 konradybcio

This was my solution which also covers pm8841 and pma8084 https://github.com/z3ntu/lk2nd/commit/5e147f7056ee0b080a5e224c68de6927a212288a

z3ntu avatar May 14 '21 14:05 z3ntu

WHy not have separate structs for each?

minlexx avatar May 14 '21 15:05 minlexx

If you mean pma8084 vs pm8941, you'd need to query the pmic id from smem and choose the correct struct based on that - which is more complicated.

z3ntu avatar May 14 '21 20:05 z3ntu

lk already does this (parse smem etc)

minlexx avatar May 15 '21 17:05 minlexx

Sorry, this PR got a bit stale... Lately we were trying to refactor lk2nd so I'm not sure if this change is still relevant thus I'm closing it. If you want to respin it, please feel free to reopen or re-target to the experimental-tmp2 branch.

TravMurav avatar Apr 06 '23 16:04 TravMurav