lk2nd icon indicating copy to clipboard operation
lk2nd copied to clipboard

[experimental-tmp2] dts: msm8226: Add HTC One Mini 2

Open z3ntu opened this issue 2 years ago • 3 comments

We need to use a different scratch region since the one typically used is reserved for something else and just returns zeroes when read.

memul:/ # cat /sys/kernel/debug/memblock/memory
   0: 0x00000000..0x05afffff
   1: 0x05d00000..0x074fffff
   2: 0x11600000..0x3f9fffff
memul:/ # cat /sys/kernel/debug/memblock/reserved
   0: 0x00000000..0x00007fff
   1: 0x00100000..0x01522f1b
   2: 0x01e00000..0x01e2e401
   3: 0x02008000..0x02160d47
   4: 0x05b00000..0x05bcffff
   5: 0x2b400000..0x2fffffff
   6: 0x302cb000..0x302fefff
   7: 0x302ffda0..0x302fffff

z3ntu avatar Sep 04 '23 15:09 z3ntu

@stephan-gh Do you think I can recommend people on the pmOS wiki page for this device to pull this branch and build it to use on that phone?

Or shall I spend some effort porting this device to the main branch so it's more easily part of the next release there? Not sure what we can do about this different scratch region in any case...

z3ntu avatar Sep 12 '23 20:09 z3ntu

I don't know how to handle the difference in the scratch region properly yet. Perhaps it's easiest if we only merge the DT as first step and recommend people to override the region when building like

$ make TOOLCHAIN_PREFIX=... SCRATCH_ADDR=0x20000000 SCRATCH_SIZE=0x10000000 lk2nd-msm8916

I think this should work on both branches?

stephan-gh avatar Sep 13 '23 08:09 stephan-gh

Thanks for the help! At least in main branch this appears to work well! See #300 (incl. the comment in the dts file). Still keeping this open for experimental-tmp2 branch :) Do you plan on merging PRs with dts into this branch or not? If yes I can also make this branch ready with the SCRATCH_ADDR changes like in master.

z3ntu avatar Sep 15 '23 20:09 z3ntu

The branches were switched and memul dts is included already with the note. Thanks!

TravMurav avatar May 27 '24 13:05 TravMurav