linux icon indicating copy to clipboard operation
linux copied to clipboard

Add device tree for ASUS ZenPad 8.0

Open vm03 opened this issue 2 years ago • 6 comments

vm03 avatar Feb 04 '23 10:02 vm03

Consider joining #msm8916:postmarketos.org for discussions.

Looks much better. There are something to do about the commit messages:

  • Signoff. See the logs
  • Add proper commit messages. For example, b3a6b088289ee0586b7f1f4977ade6dae06a009a

Just a note. It's not clear whether we should apply the following changes: - https://lore.kernel.org/lkml/[email protected]/ - https://lore.kernel.org/lkml/[email protected]/ - https://lore.kernel.org/lkml/[email protected]/

The Signed-off-by tag is invalid. You have to use full name. For example: Signed-off-by: Random J Developer <[email protected]>

Ref: https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :(

vm03 avatar Feb 09 '23 16:02 vm03

@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :(

The current one is valid and looks good.

arm64: dts: qcom: Add device tree for ASUS ZenPad 8.0

ASUS ZenPad 8.0 is a tablet using the MSM8916 SoC.

Add device tree with initial support for:

  • ...
  • Vibrator

Did you add it? I don't see any vibrator in the device tree.

@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :(

The current one is valid and looks good.

arm64: dts: qcom: Add device tree for ASUS ZenPad 8.0 ASUS ZenPad 8.0 is a tablet using the MSM8916 SoC. Add device tree with initial support for:

  • ...
  • Vibrator

Did you add it? I don't see any vibrator in the device tree.

No. Vibration at poweron misled me.

vm03 avatar Feb 09 '23 17:02 vm03