msk-markdown icon indicating copy to clipboard operation
msk-markdown copied to clipboard

Add window event

Open KhantParthkumarA opened this issue 4 years ago • 6 comments

Why needed these changes?

  • Model should be reset on window click

Have you tested these changes?

  • Yes

Any updates require?

  • No

KhantParthkumarA avatar Oct 02 '21 18:10 KhantParthkumarA

✔️ Deploy Preview for msk-markdown ready!

🔨 Explore the source changes: 7e598c93e773d32dcbed5bc2ba1fb90216cd5f8d

🔍 Inspect the deploy log: https://app.netlify.com/sites/msk-markdown/deploys/6158a49155fc1100077b7e70

😎 Browse the preview: https://deploy-preview-22--msk-markdown.netlify.app

netlify[bot] avatar Oct 02 '21 18:10 netlify[bot]

What about the save modal?

Save modal

Settings, about and save modal. Did I miss something?

kevinmahrous avatar Oct 03 '21 21:10 kevinmahrous

What about the save modal?

Save modal

Settings, about and save modal. Did I miss something?

Yes we've to add model reset for save also, I'll update it

KhantParthkumarA avatar Oct 04 '21 02:10 KhantParthkumarA

Don't we do the same thing here:

const AboutOnClick = ({
    target
}) => {
    if (target === About) {
        OpenCloseAbout();
    }
};

kevinmahrous avatar Oct 04 '21 16:10 kevinmahrous

Don't we do the same thing here:

const AboutOnClick = ({
    target
}) => {
    if (target === About) {
        OpenCloseAbout();
    }
};

Window events how we can handle in this function call?

KhantParthkumarA avatar Oct 04 '21 16:10 KhantParthkumarA

@kevinmmansour Let me know if anything need to update

KhantParthkumarA avatar Oct 05 '21 17:10 KhantParthkumarA