msk-markdown icon indicating copy to clipboard operation
msk-markdown copied to clipboard

Sample markdown button

Open KhantParthkumarA opened this issue 4 years ago • 11 comments

Why needed these changes?

  • Get a sample of markdown

Have you tested these changes?

  • Yes

Any updates require?

  • No

KhantParthkumarA avatar Oct 01 '21 17:10 KhantParthkumarA

✔️ Deploy Preview for msk-markdown ready!

🔨 Explore the source changes: ea32e562074976e066bd0af52e2910478859ae4c

🔍 Inspect the deploy log: https://app.netlify.com/sites/msk-markdown/deploys/615745ea3ba11800081d4f06

😎 Browse the preview: https://deploy-preview-20--msk-markdown.netlify.app/

netlify[bot] avatar Oct 01 '21 17:10 netlify[bot]

I was added Sample button style in the last commit, but it not showing a live preview, please verify

KhantParthkumarA avatar Oct 01 '21 17:10 KhantParthkumarA

I've used a sample reference from here - https://markdown-it.github.io/ Let me know if need to update urls etc

KhantParthkumarA avatar Oct 01 '21 17:10 KhantParthkumarA

I see there are explanations about features we don't support yet. Delete the following:

  • Advertisement
  • Typographic replacement
  • Right-Aligned table columns
  • Subscript, Superscript
  • Inserted, Marked Text
  • Footnotes
  • Abbreviations
  • Custom Containers

Plus, all the links there are connected to markdown-it wikis. We'll need to change them, too.

lee-jongwoo avatar Oct 02 '21 04:10 lee-jongwoo

I see there are explanations about features we don't support yet. Delete the following:

  • Advertisement
  • Typographic replacement
  • Right-Aligned table columns
  • Subscript, Superscript
  • Inserted, Marked Text
  • Footnotes
  • Abbreviations
  • Custom Containers

Plus, all the links there are connected to markdown-it wikis. We'll need to change them, too.

Okay

KhantParthkumarA avatar Oct 02 '21 09:10 KhantParthkumarA

There's a lot of problems here, I think we should redesign the header because it's started to be long, this's how it looks like on my device:

image

The scrollbar started to be annoying, let me just redesign and I'll be back to this pull request as well as a notice for @KhantParthkumarA, that the "Sample" button looks black - I haven't reviewed the code, so I don't know where's the problem and we don't allow advertisement - sorry, even I as a maintainer I work a lot for this project and it's open source - the project aims and developed to be a good markdown text editor and help people to write READMEs and text files for their projects simply. As well as I would thank @lee-jongwoo for their time.

kevinmahrous avatar Oct 02 '21 14:10 kevinmahrous

I haven't reviewed the code, so I don't know where's the problem and we don't allow advertisement - sorry, even I as a maintainer I work a lot for this project and it's open source - the project aims and developed to be a good markdown text editor and help people to write READMEs and text files for their projects simply. As well as I would thank @lee-jongwoo for their time.

I'll remove advertisements and other links related changes that mention by @lee-jongwoo. About the black color, I've already update styles in the last commit and doubly checked locally, It's seen fine locally, I think the last changes aren't showing on live preview as I was mentioned

KhantParthkumarA avatar Oct 02 '21 16:10 KhantParthkumarA

@kevinmmansour I'm actually thinking about using font-awesome icons. They have all the icons we need (displaying 'link' as 'a' is probably not a good idea) and icons cover less space than text. I actually tried that: 스크린샷 2021-10-03 오전 7 59 19 It looked awesome. (just got up, 7AM in the morning now)

lee-jongwoo avatar Oct 02 '21 23:10 lee-jongwoo

@kevinmmansour I'm actually thinking about using font-awesome icons. They have all the icons we need (displaying 'link' as 'a' is probably not a good idea) and icons cover less space than text. I actually tried that: 스크린샷 2021-10-03 오전 7 59 19 It looked awesome. (just got up, 7AM in the morning now)

Oh, nice work! I'm also thinking about adding more markdown stuff like "H4", "H5", "H6" and etc. But the problem that there's no space for that.

kevinmahrous avatar Oct 03 '21 14:10 kevinmahrous

@lee-jongwoo In order to don't add much comments for this pull request, I have created a new GitHub discussion, so we can be clear and clean - thanks!

@KhantParthkumarA I'll be back to this pull request when I finish and push redesigning the header - because the header started to be messy.

kevinmahrous avatar Oct 03 '21 21:10 kevinmahrous

@kevinmmansour I'm actually thinking about using font-awesome icons. They have all the icons we need (displaying 'link' as 'a' is probably not a good idea) and icons cover less space than text. I actually tried that: 스크린샷 2021-10-03 오전 7 59 19 It looked awesome. (just got up, 7AM in the morning now)

Oh, nice work! I'm also thinking about adding more markdown stuff like "H4", "H5", "H6" and etc. But the problem that there's no space for that.

We can do like drop-down menus for equals features like h1, h2... we can use drop down and also we can use bold and italic dropdown and OL UL list dropdown

KhantParthkumarA avatar Oct 04 '21 02:10 KhantParthkumarA