Matt Simerson

Results 217 comments of Matt Simerson

We have two good ways to improve upon the status quo: 1. have async plugins grab a ref, `const txn = connection.transaction` 2. use [optional chaining](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining) when accessing

The only problem with optional chaining is that it requires node >= 14. At present, we still support node 12. We anticipate dropping support for node 12 when it goes...

@baudehlo , "add get_body_html() and get_body_text() functions"

Yes, else we'd have closed the issue. :)

a PR is welcome. I've looked at your TLS work and you did a nicer job than we have.

> SNICallback method has no bound context. I recall running into this issue when I added SNI support and the ability to support more than one TLS certificate. IIRC, the...

I like the idea. I'm wondering about another implementation that extends the existing note to also be an array. If it's an array, then pass the contents to a function...

> the most logical thing to do is to move this responsibility to the plugin...or by allowing to store a callable function in the note I like that idea!

Paging @haraka/core. I'd like to hear a couple more opinions on this.

You could try the patch in #2501