Mikael Simberg

> I think adding `entries.append(cmake_cache_string("CMAKE_HIP_ARCHITECTURES", "{0}".format(arch_str)))` on line ~192 might be a solution - can you give that a try @msimberg ? This seems to work for the `HIP_ARCHITECTURES` issues,...

> @msimberg - we have also seen that issue, and @trws identified a fix, something like: > > ``` > entries.append( > cmake_cache_string( > "HIP_CLANG_INCLUDE_PATH", > glob.glob( > "{}/lib/clang/*/include".format(spec['llvm-amdgpu'].prefix) >...

@davidbeckingsale I think this is the problem with `std::filesystem`: https://github.com/LLNL/Umpire/issues/771.

Fixed the style issues.

Ping @davidbeckingsale? Is there something missing from here before it can be merged? Not having this currently causes conflicts in packages that want to use CMake's HIP language support which...

> Using `CMAKE_HIP_ARCHITECTURES` would require a lowerbound on cmake version 3.21, right? > > https://cmake.org/cmake/help/latest/variable/CMAKE_HIP_ARCHITECTURES.html says new in version 3.21 > I think yes and no. Setting `CMAKE_HIP_ARCHITECTURES` doesn't hurt...

I also bumped into this issue. It seems to be due to the wrong paths being used here: https://github.com/ROCm-Developer-Tools/HIP/blob/c6b0810186510039bfa94fc68b6bf3530c63e26e/hip-lang-config.cmake.in#L108-L111. However, it's been fixed in 5.2.X: https://github.com/ROCm-Developer-Tools/HIP/blob/d6224a55390bf2d8fd0180c21bae44f0d718d1eb/hip-lang-config.cmake.in#L110-L113. That means this would...

@haampie, @trws do you think I could go ahead and merge this? I'd like to get a final ok from @davidbeckingsale but I've had trouble getting hold of him for...

Thanks @davidbeckingsale for having a look!

@spackbot run pipeline