PyGitUp icon indicating copy to clipboard operation
PyGitUp copied to clipboard

Update subprocess handling to avoid hangs / blocking.

Open bdmartin opened this issue 2 years ago • 1 comments

  • Update subprocess handling to read both stdout and stderr (to avoid hangs based on blocked pipes).
  • Add a unit test to cover that use case.
    • This test case would hang before the changes and now it does not.

bdmartin avatar Jan 01 '24 00:01 bdmartin

@msiemens - Is this something that makes sense to take?

bdmartin avatar May 13 '24 16:05 bdmartin

Hey @bdmartin, sorry for the long delay. Seems like you work with bigger repositories than me 🙂 I've merged your PR and will publish a new release in just a minute!

msiemens avatar Oct 05 '24 19:10 msiemens

Released in v2.3.0 🙂

msiemens avatar Oct 05 '24 20:10 msiemens