Mikhail Shustov

Results 69 comments of Mikhail Shustov
trafficstars

would be great to try to implement it. ideally all effects should work in the same way

> It makes more sense to me for local query settings to override connection-level settings - its been the behavior for a long time and this is the first report...

I checked our source code and it seems that saga catches an error here https://github.com/redux-saga/redux-saga/blob/63dfb94ebfaadf1b59a3e4029a1fa71c574307a4/packages/core/src/internal/proc.js#L262-L266 but because it handles an error in another function call https://github.com/redux-saga/redux-saga/blob/63dfb94ebfaadf1b59a3e4029a1fa71c574307a4/packages/core/src/internal/proc.js#L266 , browser engine (Chrome)...

I'm on vacation, so working on stuff from time to time. I've had a look at the case and some notes: on the whole it seems that we cannot get...

https://github.com/redux-saga/redux-saga/compare/flatten-stack-experiment edited: seems that's not a scheduling problem, but forking model doesn't play well with that implementation :(

> Alternative solution would be to use some kind of special completion value but that would force us to return each sync value (instead of passing it through completion callback)...

> BTW does your queue ever becoming bigger than 1? no. that's was just easier for brains to consider it as a 'queue', actually it has 0 or 1 element...

@Andarist I updated the branch to get rid of an array. Indeed I was able to fix the failed test with adding in https://github.com/redux-saga/redux-saga/blob/master/packages/core/src/internal/runSaga.js ```diff + suspend() const task =...

@Andarist I'm a bit confused, since it's absolutely the same fix as https://github.com/redux-saga/redux-saga/pull/1628

@Andarist completely agree from this point of view, will put on block until https://github.com/redux-saga/redux-saga/pull/1628 is merged